Attention is currently required from: cron2, flichtenheld, its_Giaan, ordex,
plaisthos.
Hello cron2, flichtenheld, ordex, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/941?usp=email
to look at the new patch set (#5).
The following approv
Attention is currently required from: cron2, flichtenheld, ordex, plaisthos.
its_Giaan has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/941?usp=email )
Change subject: dco_linux: Introduce new uAPIs
..
Attention is currently required from: flichtenheld, its_Giaan, ordex, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/941?usp=email )
Change subject: dco_linux: Introduce new uAPIs
..
cron2 has uploaded a new patch set (#4) to the change originally created by
stipa. ( http://gerrit.openvpn.net/c/openvpn/+/944?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: win: refactor get_windows_version()
..
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/944?usp=email )
Change subject: win: refactor get_windows_version()
..
win: refactor get_windows_version()
It's 2025, and almost all clients now run on Wi
I have mildly tested this (mingw-compiled 32/64 bit binaries and tried
to find VMs to run them on, but most of this failed due to this or that or
windows in general). I did test Win7/i386 (32bit binaries on 7/64),
Win10/amd64, Win11/amd64, and the result was what I expected.
Now, with Microsoft b
Attention is currently required from: cron2, plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/961?usp=email )
Change subject: Add information-gathering about DNS resolvers configured to
t_client.sh(.in)
.
Attention is currently required from: plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/945?usp=email )
Change subject: Make --dh none behaviour default if not specified
..
Patch Set
From: Gianmarco De Gregori
This patch updates the dco userspace API to
support communication with the new in-kernel
driver.
The main change involves updating the enums
used for Netlink messages to match the
definitions expected by the kernel module.
Change-Id: I009f4e7ad38636f1c0b78d267561194c2
cron2 has uploaded a new patch set (#7) to the change originally created by
its_Giaan. ( http://gerrit.openvpn.net/c/openvpn/+/941?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: dco_linux: Introduce new uAPIs
...
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/941?usp=email )
Change subject: dco_linux: Introduce new uAPIs
..
dco_linux: Introduce new uAPIs
This patch updates the dco userspace API to
support commu
So, after quite a bit of discussion and a number of new issues opened
against backport and dco-net-next :-) - *this* patch is fine, as in,
client and server functionality work with the new in-kernel Linux DCO
module now (tested via backport to Ubuntu 20.04).
There are some known issues left - the
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/961?usp=email
to review the following change.
Change subject: Add information-gathering about DNS resolvers co
From: Frank Lichtenheld
When trying to reformat the code with a formatter
that actually checks line-lengths, these never
come out nice otherwise.
Change-Id: I7f0ba2261b61f6eed511cbd8bb2e880d774d1365
Signed-off-by: Frank Lichtenheld
Acked-by: Gert Doering
---
This change was reviewed on Gerrit
Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/792?usp=email )
Change subject: Manually reformat some long trailing comments
..
Looked at the changes, all make sense. Ran through a set of client
tests, just to make sure no accidents happened that would break things
somewhere (no breakage) - also, buildbots already stated "no breakage".
Your patch has been applied to the master branch.
commit eef30e6e72d6bb36c0c0ec29a1219
cron2 has uploaded a new patch set (#17) to the change originally created by
flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/792?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: Manually reformat some long trailing comments
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/792?usp=email )
Change subject: Manually reformat some long trailing comments
..
Manually reformat some long trailing comments
When trying to reformat the
From: Lev Stipakov
It's 2025, and almost all clients now run on Windows 10 or newer.
Instead of displaying:
"Windows version 10.0 (Windows 10 or greater), amd64 executable"
we now show the exact build number, e.g.:
"Windows version: 10.0.22631,amd64"
Remove "pre-Win7" checks in a few plac
Attention is currently required from: flichtenheld, plaisthos, stipa.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/944?usp=email )
Change subject: win: refactor get_windows_version()
..
Pat
Attention is currently required from: cron2, flichtenheld, ordex, plaisthos.
Hello cron2, flichtenheld, ordex, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/941?usp=email
to look at the new patch set (#6).
Change subject: dco_linux: Intr
From: Antonio Quartulli
In case of UDP peer timeout, an openvpn client (userspace)
performs the following actions:
1. receives the peer deletion notification (reason=timeout)
2. closes the socket
Upon 1. we have the following:
- ovpn_peer_keepalive_work()
- ovpn_socket_release()
- synchronize
Hello flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/961?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Code-Review+2 by flichtenheld
Change subject: Add information-gathe
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/961?usp=email )
Change subject: Add information-gathering about DNS resolvers configured to
t_client.sh(.in)
..
Add information-gathering about DNS resolv
Thanks for the review.
Patch has been tested on ubuntu 20.04 with systemd-resolvd and FreeBSD
with resolvconf (cat /etc/resolv.conf), and BB has tested all the other
platforms (... to the point that nothing breaks, the DNS stuff is still
not in yet).
Patch has been applied to the master branch.
With the patchsets to add DNS configuration on Unix+MacOS systems, and
the addition of test stanzas to excercise and verify the OS specific
"dns-updown" script, it becomes important to trace test failures
("did it not ping because the DNS was not installed, or did something
else fail?") and also ve
26 matches
Mail list logo
