Attention is currently required from: cron2, flichtenheld, ordex, plaisthos.
its_Giaan has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/941?usp=email ) Change subject: dco_linux: Introduce new uAPIs ...................................................................... Patch Set 5: (4 comments) File src/openvpn/dco_linux.c: http://gerrit.openvpn.net/c/openvpn/+/941/comment/42a3e9d5_a3241db0 : PS4, Line 547: return -1; > this change looks unneccessary? Done http://gerrit.openvpn.net/c/openvpn/+/941/comment/72dedff9_08f21440 : PS4, Line 574: } > same here... […] Done http://gerrit.openvpn.net/c/openvpn/+/941/comment/88df7038_9eb77ae3 : PS4, Line 591: keyconf = nla_nest_start(nl_msg, OVPN_A_KEYCONF); > why wrap differently, and not keep `struct nlattr * nla_nest_start()... […] Done http://gerrit.openvpn.net/c/openvpn/+/941/comment/fd7c904e_d3273a61 : PS4, Line 860: case OVPN_CMD_KEY_SWAP_NTF: > what is KEY_SWAP_NTF? That's a new thing :-) The 'NTF' prefix indicates that the message comes from the kernel module. So we can distinguish between messages sent and received. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/941?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I009f4e7ad38636f1c0b78d267561194c2bb4c051 Gerrit-Change-Number: 941 Gerrit-PatchSet: 5 Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: ordex <anto...@mandelbit.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: cron2 <g...@greenie.muc.de> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: ordex <anto...@mandelbit.com> Gerrit-Comment-Date: Mon, 05 May 2025 07:22:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <g...@greenie.muc.de> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
