I have mildly tested this (mingw-compiled 32/64 bit binaries and tried
to find VMs to run them on, but most of this failed due to this or that or
windows in general).  I did test Win7/i386 (32bit binaries on 7/64),
Win10/amd64, Win11/amd64, and the result was what I expected.

Now, with Microsoft being as silly as they are, we could just hardcode
the first two digits - all versions are "10.0" now, with a build number
3rd...  but hey, maybe KI will make them return to useful versioning one
day, and then our use of the API stands ready!

Your patch has been applied to the master branch.

commit 45a4f4e5f6c3552a27a8064ab6a857c465efc2f0
Author: Lev Stipakov
Date:   Mon May 5 14:27:06 2025 +0200

     win: refactor get_windows_version()

     Signed-off-by: Lev Stipakov <l...@openvpn.net>
     Acked-by: Gert Doering <g...@greenie.muc.de>
     Message-Id: <20250505122712.5214-1-g...@greenie.muc.de>
     URL: 
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg31566.html
     Signed-off-by: Gert Doering <g...@greenie.muc.de>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to