Attention is currently required from: d12fk, flichtenheld, plaisthos, stipa.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/824?usp=email )
Change subject: dns: support multiple domains without DHCP
..
From: Heiko Hund
Instead of using wmic on Windows to set one (the first) DNS domain,
modify the registry directly and let the resolver know that something
changed.
This fixes that more than one search domain suffix could only be applied
when DHCP and the tap driver was used. Now this works as we
I have stared at the code for quite a while and it should do what it
intends to do. Lev has tested it and +2'ed based on the test results.
There is one thing we need to re-test (will it behave properly if two
concurrent VPN sessions modify the global search list), but the standard
case is a "per
cron2 has uploaded a new patch set (#14) to the change originally created by
d12fk. ( http://gerrit.openvpn.net/c/openvpn/+/824?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: dns: support multiple domains without DHCP
..
cron2 has uploaded a new patch set (#14) to the change originally created by
d12fk. ( http://gerrit.openvpn.net/c/openvpn/+/825?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by stipa
Change subject: dns: do not use netsh to set name server addresses
..
Stared at code, looks reasonable.
There is a bit of unsafe code (the address copying loop will overrun *if*
we ever increase the number of allowed addresses in dns_cfg_message_t
and forget to increase this buffer) - but it cannot overflow with anything
accepted today, and increasing the message si
Attention is currently required from: d12fk, flichtenheld, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/825?usp=email )
Change subject: dns: do not use netsh to set name server addresses
.
Attention is currently required from: d12fk, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/840?usp=email )
Change subject: dns: don't publish env vars to non-dns scripts
..
Patch
On 27/02/2025 04:25, Qingfang Deng wrote:
When multihome option is enabled, OpenVPN passes ipi_addr to DCO, which
is always 0.0.0.0. It should use ipi_spec_dst instead.
Signed-off-by: Qingfang Deng
---
src/openvpn/dco.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/
Attention is currently required from: flichtenheld, plaisthos.
d12fk has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/905?usp=email )
Change subject: win: match search domains when creating exclude rules
.
Meeting summary for 12 March 2025:
* *Updated: security mailing list*
/Both community and company want to be in control of security
mailing list. We need some resolution./
/novaflash suggested to nominate ordex and cron2 as representatives
of community to discuss directly with andrew
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/825?usp=email )
Change subject: dns: do not use netsh to set name server addresses
..
dns: do not use netsh to set name server addresses
Instead of spawni
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/906?usp=email
to review the following change.
Change subject: win: allow OpenVPN service account to use any co
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/824?usp=email )
Change subject: dns: support multiple domains without DHCP
..
dns: support multiple domains without DHCP
Instead of using wmic on Windows
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/907?usp=email
to review the following change.
Change subject: socket: don't transfer bind family to socket in
15 matches
Mail list logo
