Stared at code, looks reasonable.
There is a bit of unsafe code (the address copying loop will overrun *if*
we ever increase the number of allowed addresses in dns_cfg_message_t
and forget to increase this buffer) - but it cannot overflow with anything
accepted today, and increasing the message size is not something trivially
done.
Lev has tested that it actually works :-)
Since mail-archive.org is broken again I've referenced the sf.net mail
archive (+ the gerrit URL) instead.
Your patch has been applied to the master branch.
commit 99b35c3783477b837735cff0aa1cf7c5ba4aa366
Author: Heiko Hund
Date: Wed Mar 12 11:11:50 2025 +0100
dns: do not use netsh to set name server addresses
Signed-off-by: Heiko Hund <he...@ist.eigentlich.net>
Acked-by: Lev Stipakov <lstipa...@gmail.com>
Message-Id: <20250312101156.5756-1-g...@greenie.muc.de>
URL: https://sourceforge.net/p/openvpn/mailman/message/59159531/
URL: https://gerrit.openvpn.net/c/openvpn/+/825
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
