I have stared at the code for quite a while and it should do what it
intends to do. Lev has tested it and +2'ed based on the test results.
There is one thing we need to re-test (will it behave properly if two
concurrent VPN sessions modify the global search list), but the standard
case is a "per interface" searchlist, so this is rare enough to not
hold up the DNS patch series further (*if* there is an issue lurking,
it will be "not properly cleaned up", but no "crash or anything").
Test compiled on Ubuntu 2204/MinGW64, no (new) warnings.
Your patch has been applied to the master branch.
commit ae90cbad50641cdf2579d1a6bcc35144866f68b1
Author: Heiko Hund
Date: Wed Mar 12 10:22:53 2025 +0100
dns: support multiple domains without DHCP
Signed-off-by: Heiko Hund <he...@ist.eigentlich.net>
Acked-by: Gert Doering <g...@greenie.muc.de>
Message-Id: <20250312092259.26487-1-g...@greenie.muc.de>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg31108.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
