[Openvpn-devel] [S] Change in openvpn[master]: Refactor methods to use the actual state of tun rather the options st...

2024-09-18 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/753?usp=email ) Change subject: Refactor methods to use the actual state of tun rather the options struct

[Openvpn-devel] [S] Change in openvpn[master]: configure: Review use of standard AC macros

2024-09-18 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#4) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/674?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: configure: Review use of standard AC macros ...

[Openvpn-devel] [S] Change in openvpn[master]: configure: Review use of standard AC macros

2024-09-18 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/674?usp=email ) Change subject: configure: Review use of standard AC macros .. configure: Review use of standard AC macros - Increase required version to

[Openvpn-devel] [M] Change in openvpn[master]: Change dev null to be a driver type instead of a special mode of tun/tap

2024-09-18 Thread plaisthos (Code Review)
Attention is currently required from: plaisthos. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/748?usp=email to look at the new patch set (#9). Change subject: Change dev null to be a driver type instead of a special mode of tu

[Openvpn-devel] [S] Change in openvpn[master]: Refactor methods to use the actual state of tun rather the options st...

2024-09-18 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/753?usp=email to review the following change. Change subject: Refactor methods to use the actual state of tun rather the options st

[Openvpn-devel] [S] Change in openvpn[master]: Refactor methods to use the actual state of tun rather the options st...

2024-09-18 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/753?usp=email ) Change subject: Refactor methods to use the actual state of tun rather the options struct ...

[Openvpn-devel] [M] Change in openvpn[master]: Change dev null to be a driver type instead of a special mode of tun/tap

2024-09-18 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/748?usp=email ) Change subject: Change dev null to be a driver type instead of a special mode of tun/tap

[Openvpn-devel] [L] Change in openvpn[master]: Introduce DRIVER_AFUNIX backend for use with lwipovpn

2024-09-18 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/747?usp=email to look at the new patch set (#7). Change subject: Introduce DRIVER_AFUNIX backend for use with lwipovpn ..

[Openvpn-devel] [M] Change in openvpn[master]: Change dev null to be a driver type instead of a special mode of tun/tap

2024-09-18 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/748?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Code-Review-1 by flichtenh

[Openvpn-devel] [S] Change in openvpn[master]: Automatically enable ifconfig-exec/route-exec behaviour for afunix tu...

2024-09-18 Thread plaisthos (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. Hello cron2, flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/750?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Co

[Openvpn-devel] [M] Change in openvpn[master]: Move to common backend_driver type in struct tuntap

2024-09-18 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/738?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Code-Review-1 by flichtenh

[Openvpn-devel] [M] Change in openvpn[master]: Change dev null to be a driver type instead of a special mode of tun/tap

2024-09-18 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/748?usp=email to look at the new patch set (#8). Change subject: Change dev null to be a driver type instead of a special mode o

[Openvpn-devel] [M] Change in openvpn[master]: Change dev null to be a driver type instead of a special mode of tun/tap

2024-09-18 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/748?usp=email ) Change subject: Change dev null to be a driver type instead of a special mode of tun/tap

[Openvpn-devel] [M] Change in openvpn[master]: Add building/testing with msbuild and the clang compiler

2024-09-18 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/751?usp=email ) Change subject: Add building/testing with msbuild and the clang compiler .

[Openvpn-devel] [PATCH] make t_server_null "server alive?" check more robust

2024-09-18 Thread Gert Doering
- use "$RUN_SUDO kill -0 $pid" to test if a given process is running, not "ps -p $pid" - the latter will not work if security.bsd.see_other_uids=0 is set - produce proper error messages if pid files can not be found or are empty at server shutdown time --- tests/t_server_null_client.sh | 5

[Openvpn-devel] IRC community meeting summary

2024-09-18 Thread Johan Draaisma
Meeting summary for 18 September 2024: * *Updated: OpenVPN community meetup 2024* /Hotel recommendation added; Hotel Santo in Karlsruhe./ /Wiki coordination page:​https://community.openvpn.net/openvpn/wiki/CommunityMeetup2024

[Openvpn-devel] [M] Change in openvpn[master]: Add building/testing with msbuild and the clang compiler

2024-09-18 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/751?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review-1 by flichtenh

[Openvpn-devel] [M] Change in openvpn[master]: Add building/testing with msbuild and the clang compiler

2024-09-18 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/751?usp=email ) Change subject: Add building/testing with msbuild and the clang compiler .

[Openvpn-devel] [M] Change in openvpn[master]: Change dev null to be a driver type instead of a special mode of tun/tap

2024-09-18 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/748?usp=email ) Change subject: Change dev null to be a driver type instead of a special mode of tun/tap

[Openvpn-devel] [M] Change in openvpn[master]: tests: Allow to test for arbitrary ciphers and digests

2024-09-18 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/752?usp=email to review the following change. Change subject: tests: Allow to test for arbitrary ciphers and digests .

[Openvpn-devel] [L] Change in openvpn[master]: Support CIDR on options and extend netbits usage

2024-09-18 Thread ralf_lici (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ralf_lici has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/739?usp=email ) Change subject: Support CIDR on options and extend netbits usage ..

[Openvpn-devel] [L] Change in openvpn[master]: Introduce DRIVER_AFUNIX backend for use with lwipovpn

2024-09-18 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/747?usp=email ) Change subject: Introduce DRIVER_AFUNIX backend for use with lwipovpn ..

[Openvpn-devel] [M] Change in openvpn[master]: Move to common backend_driver type in struct tuntap

2024-09-18 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/738?usp=email ) Change subject: Move to common backend_driver type in struct tuntap .. P

[Openvpn-devel] [L] Change in openvpn[master]: Support CIDR on options and extend netbits usage

2024-09-18 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos, ralf_lici. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/739?usp=email ) Change subject: Support CIDR on options and extend netbits usage ..

[Openvpn-devel] [M] Change in openvpn[master]: Add building/testing with msbuild and the clang compiler

2024-09-18 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/751?usp=email ) Change subject: Add building/testing with msbuild and the clang compiler .

[Openvpn-devel] [M] Change in openvpn[master]: tests: Allow to test for arbitrary ciphers and digests

2024-09-18 Thread flichtenheld (Code Review)
flichtenheld has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/752?usp=email ) Change subject: tests: Allow to test for arbitrary ciphers and digests .. Abandoned Use --show-ciphers instead -- To view, visit h

[Openvpn-devel] [PATCH v1] socket: Change return types of link_socket_write* to ssize_t

2024-09-18 Thread Gert Doering
From: Frank Lichtenheld This is the actual return value of send/sendto/sendmsg. We will leave it to the single caller of link_socket_write() to decide how to map that to the int buffer world. For now just cast it explicitly. Change-Id: I7852c06d331326c1dbab7b642254c0c00d4cebb8 Signed-off-by: Fra

[Openvpn-devel] [PATCH applied] Re: configure: Review use of standard AC macros

2024-09-18 Thread Gert Doering
I admit that I have no deep understanding of autoconf, but I did check that "about everything" has more recent autoconf versions than 2.60 ("the gold standard" has been 2.69 for many years) and that all our buildbots and GHA are building fine with these changes. Half of them are typo fixes or whit

[Openvpn-devel] [PATCH v3] configure: Review use of standard AC macros

2024-09-18 Thread Gert Doering
From: Frank Lichtenheld - Increase required version to 2.60 since that is documented minimum version for AC_USE_SYSTEM_EXTENSIONS - Remove obsolete macros AC_C_CONST and AC_C_VOLATILE. They are noops on every compiler we support. - Add explicit call to AC_PROG_CC. We get this implictly as d

[Openvpn-devel] [S] Change in openvpn[master]: configure: Review use of standard AC macros

2024-09-18 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/674?usp=email ) Change subject: configure: Review use of standard AC macros .. Pa

[Openvpn-devel] [S] Change in openvpn[master]: socket: Change return types of link_socket_write* to ssize_t

2024-09-18 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/740?usp=email ) Change subject: socket: Change return types of link_socket_write* to ssize_t ..

[Openvpn-devel] [S] Change in openvpn[master]: Refactor methods to use the actual state of tun rather the options st...

2024-09-18 Thread plaisthos (Code Review)
Attention is currently required from: cron2, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/753?usp=email ) Change subject: Refactor methods to use the actual state of tun rather the options struct

[Openvpn-devel] [S] Change in openvpn[master]: socket: Change return types of link_socket_write* to ssize_t

2024-09-18 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/740?usp=email ) Change subject: socket: Change return types of link_socket_write* to ssize_t .. socket: Change return types of link_socket_write* to ssize_

[Openvpn-devel] [S] Change in openvpn[master]: socket: Change return types of link_socket_write* to ssize_t

2024-09-18 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/740?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: socket: Change return types of link_socket_write* to ss

[Openvpn-devel] [PATCH applied] Re: socket: Change return types of link_socket_write* to ssize_t

2024-09-18 Thread Gert Doering
This is fallout from the -Wconversion patch set (commit 53449cb61f) where it turned out that the whole link_socket* call chain used inconsistent return types - so now it's consistent with sendmsg() etc., all using ssize_t. Stared-at-code and asked GHA :-) Your patch has been applied to the master