Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/753?usp=email )
Change subject: Refactor methods to use the actual state of tun rather the options struct ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/openvpn/dco.c: http://gerrit.openvpn.net/c/openvpn/+/753/comment/3d324953_82de2ce7 : PS1, Line 634: if (tun_dco_enabled(m->top.c1.tuntap)) this does not look correct - it goes from "if(!dco_enabled)" to "if(tun_dco_enabled)" without `!`. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/753?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ib8ba2b63ea9fd1944ff07f69c545a880e464680c Gerrit-Change-Number: 753 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Wed, 18 Sep 2024 19:07:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
