Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/751?usp=email )
Change subject: Add building/testing with msbuild and the clang compiler ...................................................................... Patch Set 4: Code-Review-1 (2 comments) File CMakePresets.json: http://gerrit.openvpn.net/c/openvpn/+/751/comment/5870527b_92367fa6 : PS4, Line 145: arm64 Why no support for ARM64? File src/openvpnmsica/openvpnmsica.h: http://gerrit.openvpn.net/c/openvpn/+/751/comment/ca83f549_dbf9a388 : PS4, Line 69: /* Ensure that clang-cl, which does not understand the #pragma comment(linker, ...) That comment seems more suited to the changes to openvpnmsica.c? Maybe instead of "#pragma comment" just write "cl-specific pragmas"? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/751?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I43d84034f3e920a45731c4aab4f851a60921290d Gerrit-Change-Number: 751 Gerrit-PatchSet: 4 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Comment-Date: Wed, 18 Sep 2024 10:40:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
