[Openvpn-devel] [L] Change in openvpn[master]: Support CIDR on options and extend netbits usage

2024-09-16 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos, ralf_lici. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/739?usp=email ) Change subject: Support CIDR on options and extend netbits usage ..

[Openvpn-devel] [XS] Change in openvpn[master]: Move cipher/data-ciphers warning to D_LOW (verb 4)

2024-09-16 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/746?usp=email to review the following change. Change subject: Move cipher/data-ciphers warning to D_LOW (verb 4) ...

[Openvpn-devel] [L] Change in openvpn[master]: Introduce DRIVER_AFUNIX backend for use with lwipovpn

2024-09-16 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/747?usp=email to review the following change. Change subject: Introduce DRIVER_AFUNIX backend for use with lwipovpn

[Openvpn-devel] [S] Change in openvpn[master]: Automatically enable ifconfig-exec/route-exec behaviour for afunix tu...

2024-09-16 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/750?usp=email to review the following change. Change subject: Automatically enable ifconfig-exec/route-exec behaviour for afunix tu

[Openvpn-devel] [M] Change in openvpn[master]: Move to common backend_driver type in struct tuntap

2024-09-16 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/738?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review-1 by

[Openvpn-devel] [S] Change in openvpn[master]: Use print_tun_backend_driver instead of custom code to print type

2024-09-16 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/749?usp=email to review the following change. Change subject: Use print_tun_backend_driver instead of custom code to print type ...

[Openvpn-devel] [XS] Change in openvpn[master]: Make read/write_tun_header static

2024-09-16 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/745?usp=email to review the following change. Change subject: Make read/write_tun_header static

[Openvpn-devel] [M] Change in openvpn[master]: Change dev null to be a driver type instead of a special mode of tun/tap

2024-09-16 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/748?usp=email to review the following change. Change subject: Change dev null to be a driver type instead of a special mode of tun/

[Openvpn-devel] [XS] Change in openvpn[master]: Move cipher/data-ciphers warning to D_LOW (verb 4)

2024-09-16 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/746?usp=email ) Change subject: Move cipher/data-ciphers warning to D_LOW (verb 4)

[Openvpn-devel] [XS] Change in openvpn[master]: Move cipher/data-ciphers warning to D_LOW (verb 4)

2024-09-16 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/746?usp=email ) Change subject: Move cipher/data-ciphers warning to D_LOW (verb 4)

[Openvpn-devel] [PATCH v1] Move cipher/data-ciphers warning to D_LOW (verb 4)

2024-09-16 Thread Gert Doering
From: Arne Schwabe These warnings served a purpose in OpenVPN 2.6.x to warn people about the changed behaviour. But for 2.7 this is will be more log spam than a helpful message. So only show this warning on a high verbosity level. Change-Id: Ie2797a82ad769cb640440d1ba7dfeb416e7b932d Signed-off-b

[Openvpn-devel] [XS] Change in openvpn[master]: Move cipher/data-ciphers warning to D_LOW (verb 4)

2024-09-16 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/746?usp=email ) Change subject: Move cipher/data-ciphers warning to D_LOW (verb 4)

[Openvpn-devel] [XS] Change in openvpn[master]: Make read/write_tun_header static

2024-09-16 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/745?usp=email ) Change subject: Make read/write_tun_header static .. Patch Set 1:

[Openvpn-devel] [PATCH v1] Make read/write_tun_header static

2024-09-16 Thread Gert Doering
From: Arne Schwabe These functions are not used outside tun.c Change-Id: I028634dba74a273c725b0beb16b674897b3c23fa Signed-off-by: Arne Schwabe Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: ht

[Openvpn-devel] [L] Change in openvpn[master]: Introduce DRIVER_AFUNIX backend for use with lwipovpn

2024-09-16 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/747?usp=email to look at the new patch set (#2). Change subject: Introduce DRIVER_AFUNIX backend for use with lwipovpn ..

[Openvpn-devel] [PATCH applied] Re: Make read/write_tun_header static

2024-09-16 Thread Gert Doering
Verified that it's not used outside tun.c, test built OpenBSD (which uses this). Your patch has been applied to the master branch. commit ac3a7fd93542420f12d58e5c7490076b5741fb5a Author: Arne Schwabe Date: Mon Sep 16 15:34:35 2024 +0200 Make read/write_tun_header static Signed-off-b

[Openvpn-devel] [XS] Change in openvpn[master]: Make read/write_tun_header static

2024-09-16 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#3) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/745?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: Make read/write_tun_header static

[Openvpn-devel] [XS] Change in openvpn[master]: Make read/write_tun_header static

2024-09-16 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/745?usp=email ) Change subject: Make read/write_tun_header static .. Make read/write_tun_header static These functions are not used outside tun.c Change-

[Openvpn-devel] [L] Change in openvpn[master]: Introduce DRIVER_AFUNIX backend for use with lwipovpn

2024-09-16 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/747?usp=email ) Change subject: Introduce DRIVER_AFUNIX backend for use with lwipovpn ..

[Openvpn-devel] [L] Change in openvpn[master]: Support CIDR on options and extend netbits usage

2024-09-16 Thread ralf_lici (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ralf_lici has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/739?usp=email ) Change subject: Support CIDR on options and extend netbits usage ..

[Openvpn-devel] [S] Change in openvpn[master]: Automatically enable ifconfig-exec/route-exec behaviour for afunix tu...

2024-09-16 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/750?usp=email to look at the new patch set (#3). Change subject: Automatically enable ifconfig-exec/route-exec behaviour for afu

[Openvpn-devel] [M] Change in openvpn[master]: Change dev null to be a driver type instead of a special mode of tun/tap

2024-09-16 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/748?usp=email to look at the new patch set (#3). Change subject: Change dev null to be a driver type instead of a special mode o

[Openvpn-devel] [L] Change in openvpn[master]: Introduce DRIVER_AFUNIX backend for use with lwipovpn

2024-09-16 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/747?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review-1 by

[Openvpn-devel] [M] Change in openvpn[master]: Move to common backend_driver type in struct tuntap

2024-09-16 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/738?usp=email ) Change subject: Move to common backend_driver type in struct tuntap .. P

[Openvpn-devel] [L] Change in openvpn[master]: Introduce DRIVER_AFUNIX backend for use with lwipovpn

2024-09-16 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/747?usp=email to look at the new patch set (#4). Change subject: Introduce DRIVER_AFUNIX backend for use with lwipovpn