Attention is currently required from: plaisthos, ralf_lici. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/739?usp=email )
Change subject: Support CIDR on options and extend netbits usage ...................................................................... Patch Set 3: (12 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/739/comment/af57c291_7928346b : PS3, Line 9: Add support for CIDR notation on all suitable options (client-nat, Maybe give some more motivation here. Why is this good for users? Is the assumption that this notation is easier to use for users? Patchset: PS3: Finished with first pass over the whole change. File src/openvpn/route.c: http://gerrit.openvpn.net/c/openvpn/+/739/comment/442c7c8d_d509e97e : PS3, Line 324: const in_addr_t default_netbits = IPV4_NETBITS_HOST; unsigned int? http://gerrit.openvpn.net/c/openvpn/+/739/comment/49b38146_172bf62a : PS3, Line 331: const char *cidr = strchr(network, '/'); Would convert to bool here to make it clear purpose http://gerrit.openvpn.net/c/openvpn/+/739/comment/9927b3a3_4809d0a7 : PS3, Line 347: convert Want to do a drive-by fix? "a a" -> "to an"? http://gerrit.openvpn.net/c/openvpn/+/739/comment/86ce371b_4860dec8 : PS3, Line 1105: route Maybe add a 0.0.0.0/1 and 128.0.0.0/1 to the comments just to make it slightly easier to read? http://gerrit.openvpn.net/c/openvpn/+/739/comment/f88439ab_4ecf8430 : PS3, Line 1166: route ( Same (0.0.0.0/1 and 128.0.0.0/1) here. http://gerrit.openvpn.net/c/openvpn/+/739/comment/77dbbd70_ab423838 : PS3, Line 1456: Maybe we could move this into the if block? Not sure why we would create it otherwise? File src/openvpn/tun.c: http://gerrit.openvpn.net/c/openvpn/+/739/comment/cbb88db5_f07c3af6 : PS3, Line 512: const bool looks_like_netmask = addr && ((addr & 0xFF000000) == 0xFF000000); Isn't this redundant? If addr is 0 the second part never matches anyway http://gerrit.openvpn.net/c/openvpn/+/739/comment/79c39edc_b5bdb970 : PS3, Line 524: Shouldn't that be "&&" ? http://gerrit.openvpn.net/c/openvpn/+/739/comment/e80071f2_d2431db9 : PS3, Line 562: const in_addr_t public_net = public &netmask; Add space after & ? http://gerrit.openvpn.net/c/openvpn/+/739/comment/7d0d0823_03c88869 : PS3, Line 591: & Add space after & -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/739?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Iae04ad8715e40dfc76475c2c5b9a766c9604efc9 Gerrit-Change-Number: 739 Gerrit-PatchSet: 3 Gerrit-Owner: ralf_lici <r...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: ralf_lici <r...@mandelbit.com> Gerrit-Comment-Date: Mon, 16 Sep 2024 12:39:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
