Am 12.11.2023 um 14:16 schrieb Savely Krasovsky:
Hello!
I am trying to use OpenVPN3 with Golang SWIG binding. It works pretty nice, but
I have random segmentation faults without obvious reason. My current guess is
that Golang calls OpenVPN3 from various threads and library is not ready for
Thanks for the reply!
After few days I have found a major bug: a close and free client before stop()
successfully executes. After fixing this I didn't get any segfaults anymore.
Program survives very extensive tests. But after your reply I am in question
again... Sure, openvpn3 has single threa
Hi,
On 20/11/2023 10:11, Savely Krasovsky wrote:
Thanks for the reply!
After few days I have found a major bug: a close and free client before stop()
successfully executes. After fixing this I didn't get any segfaults anymore.
Program survives very extensive tests. But after your reply I am i
That's exactly what I did! Works perfectly, thanks for calming me down.
Пн, 20.11.2023 в 10:37 Antonio Quartulli писал(а):
> Hi,
>
> On 20/11/2023 10:11, Savely Krasovsky wrote:
>> Thanks for the reply!
>>
>> After few days I have found a major bug: a close and free client before
>> stop() succe
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/442?usp=email
to review the following change.
Change subject: protocol_dump: tls-crypt support
.
Am 30.10.23 um 11:58 schrieb Reynir:
Dear list,
Please find attached a patch to add support for tls-crypt packets in
protocol_dump. Currently, protocol_dump will print garbage for tls-crypt
packets.
This patch makes protocol_dump print the clear text parts of the packet
such as the auth tag
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/443?usp=email
to review the following change.
Change subject: Remove unused defined from configure and cmake config
Attention is currently required from: flichtenheld, plaisthos.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/377?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/444?usp=email
to review the following change.
Change subject: Add check for nice in cmake config
...
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/442?usp=email )
Change subject: protocol_dump: tls-crypt support
..
Patch Set 1: Code-Re
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/267?usp=email )
Change subject: Various fixes for -Wconversion errors
..
Patch Set 4: Co
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/380?usp=email )
Change subject: tun: use is_tun_p2p more consistently
..
Patch Set 1: Co
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/445?usp=email
to review the following change.
Change subject: Remove compat versionhelpers.h and remove cmake/configure check
for i
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/379?usp=email )
Change subject: Remove support for NTLM v1 proxy authentication
..
Patch
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/422?usp=email )
Change subject: sample-keys: renew for the next 10 years
..
Patch Set 1:
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/446?usp=email
to review the following change.
Change subject: Remove dead list test code
...
Attention is currently required from: plaisthos.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/365?usp=email
to look at the new patch set (#8).
Change subject: Print SSL peer signature information in handshake debug details
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/447?usp=email
to review the following change.
Change subject: Deprecate tls-exit option
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/443?usp=email )
Change subject: Remove unused defined from configure and cmake config
..
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/444?usp=email )
Change subject: Add check for nice in cmake config
..
Patch Set 1: Code-
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/445?usp=email )
Change subject: Remove compat versionhelpers.h and remove cmake/configure check
for it
..
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/449?usp=email
to review the following change.
Change subject: Allow the TLS session to send out TLS alerts
.
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/448?usp=email
to review the following change.
Change subject: Log SSL alerts more prominently
..
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/450?usp=email
to review the following change.
Change subject: Introduce report_command_status helper function
..
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/451?usp=email
to review the following change.
Change subject: Remove unused function prototype crypto_adjust_frame_parameters
..
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/447?usp=email )
Change subject: Deprecate tls-exit option
..
Patch Set 1: Code-Review-1
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/448?usp=email )
Change subject: Log SSL alerts more prominently
..
Patch Set 1: Code-Rev
Attention is currently required from: plaisthos.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/444?usp=email
to look at the new patch set (#2).
The change is no longer submittable: checks~ChecksSubmitRule is unsatisfied now.
Ch
Attention is currently required from: plaisthos.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/443?usp=email
to look at the new patch set (#2).
Change subject: Remove unused/uneeded defines from configure and cmake config
..
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/443?usp=email )
Change subject: Remove unused/uneeded defines from configure and cmake config
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/447?usp=email )
Change subject: Deprecate tls-exit option
..
Patch Set 1:
(1 comment)
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/445?usp=email )
Change subject: Remove compat versionhelpers.h and remove cmake/configure check
for it
..
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/445?usp=email )
Change subject: Remove compat versionhelpers.h and remove cmake/configure check
for it
..
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/445?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review-1 by flichtenh
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/449?usp=email )
Change subject: Allow the TLS session to send out TLS alerts
..
Patch Se
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/450?usp=email )
Change subject: Introduce report_command_status helper function
..
Patch
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/451?usp=email )
Change subject: Remove unused function prototype crypto_adjust_frame_parameters
..
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/447?usp=email )
Change subject: Deprecate tls-exit option
..
Patch Set 1:
(1 comment)
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/445?usp=email )
Change subject: Remove compat versionhelpers.h and remove cmake/configure check
for it
..
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/443?usp=email )
Change subject: Remove unused/uneeded defines from configure and cmake config
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/449?usp=email )
Change subject: Allow the TLS session to send out TLS alerts
..
Patch Se
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/449?usp=email
to look at the new patch set (#2).
Change subject: Allow the TLS session to send out TLS alerts
...
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/452?usp=email
to review the following change.
Change subject: Rename state_change to continue_tls_process
..
Attention is currently required from: plaisthos.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/448?usp=email
to look at the new patch set (#2).
The change is no longer submittable: checks~ChecksSubmitRule is unsatisfied now.
Ch
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/449?usp=email )
Change subject: Allow the TLS session to send out TLS alerts
..
Patch Se
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/452?usp=email )
Change subject: Rename state_change to continue_tls_process
..
Patch Set
Attention is currently required from: flichtenheld, plaisthos.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/452?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review-1 by
Attention is currently required from: flichtenheld, plaisthos.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/449?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by
Attention is currently required from: flichtenheld, plaisthos.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/449?usp=email
to look at the new patch set (#4).
Change subject: Allow the TLS session to send out TLS alerts
.
Your patch has been applied to the master and release/2.6 branch
("printing garbage" is arguably a bug that needs fixing).
I have taken parts of the "mail mail" into the commit message, and
added the "signed-off-by:" that the OpenVPN project wants.
I haven't actually tested it beyond "does it co
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/452?usp=email )
Change subject: Rename state_change to continue_tls_process
..
Patch Set
cron2 has abandoned this change. (
http://gerrit.openvpn.net/c/openvpn/+/442?usp=email )
Change subject: protocol_dump: tls-crypt support
..
Abandoned
merged upstream, without change id
--
To view, visit http://gerrit.openvpn.
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/404?usp=email
to review the following change.
Change subject: Backport mbed TLS 3 support to OpenVPN 2.6
.
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/452?usp=email )
Change subject: Rename state_change to continue_tls_process
..
Patch Set
Attention is currently required from: plaisthos.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/448?usp=email
to look at the new patch set (#3).
The change is no longer submittable: checks~ChecksSubmitRule is unsatisfied now.
Ch
Attention is currently required from: plaisthos.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/452?usp=email
to look at the new patch set (#3).
Change subject: Rename state_change to continue_tls_process
Attention is currently required from: flichtenheld, plaisthos.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/449?usp=email
to look at the new patch set (#5).
Change subject: Allow the TLS session to send out TLS alerts
.
57 matches
Mail list logo
