Re: [Openvpn-devel] [PATCH] Make 2nd parameter to --ifconfig-ipv6 no longer mandatory.

2021-08-10 Thread Gert Doering
Hi, On Mon, Aug 09, 2021 at 11:24:44AM +0200, Antonio Quartulli wrote: > On 06/08/2021 13:01, Gert Doering wrote: > > --ifconfig-ipv6 takes two parameters, "local ipv6 address / netbits" > > and "remote ipv6 address". > > > > We only *need* a remote ipv6 address if we are in TAP mode, want to > >

Re: [Openvpn-devel] [PATCH v3] Implement --client-crresponse script options and plugin interface

2021-08-10 Thread Antonio Quartulli
Hi, On 18/05/2021 14:26, Arne Schwabe wrote: > This is allows scripts and pluginsto parse/react to a CR_RESPONSE message > > Patch V2: doc fixes, do not put script under ENABLE_PLUGIN > Patch V3: rebase > > Signed-off-by: Arne Schwabe I have a high level question about this patch. At the mome

Re: [Openvpn-devel] [PATCH v3] Implement --client-crresponse script options and plugin interface

2021-08-10 Thread Antonio Quartulli
Hi, On 10/08/2021 11:38, Antonio Quartulli wrote: > Hi, > > On 18/05/2021 14:26, Arne Schwabe wrote: >> This is allows scripts and pluginsto parse/react to a CR_RESPONSE message >> >> Patch V2: doc fixes, do not put script under ENABLE_PLUGIN >> Patch V3: rebase >> >> Signed-off-by: Arne Schwabe

Re: [Openvpn-devel] [PATCH] Replace deprecated mbedtls DRBG update function

2021-08-10 Thread Arne Schwabe
Am 10.08.21 um 08:16 schrieb Max Fillinger: > +#if MBEDTLS_VERSION_NUMBER < 0x0210 Is that really 2.16? Looking at the API doc (https://tls.mbed.org/api/version_8h.html#adb4f54ebb33fd1a25e2c4d4480cf4936) it sounds like there should be a 16 in that number. Arne __

Re: [Openvpn-devel] [PATCH] Replace deprecated mbedtls DRBG update function

2021-08-10 Thread Maximilian Fillinger
> From: Arne Schwabe [mailto:a...@rfc2549.org] > Sent: dinsdag 10 augustus 2021 12:12 > To: Maximilian Fillinger ; openvpn- > de...@lists.sourceforge.net > Subject: Re: [Openvpn-devel] [PATCH] Replace deprecated mbedtls DRBG > update function > > Am 10.08.21 um 08:16 schrieb Max Fillinger: > > +#i

Re: [Openvpn-devel] [PATCH] Replace deprecated mbedtls DRBG update function

2021-08-10 Thread Arne Schwabe
Am 10.08.21 um 12:17 schrieb Maximilian Fillinger: >> From: Arne Schwabe [mailto:a...@rfc2549.org] >> Sent: dinsdag 10 augustus 2021 12:12 >> To: Maximilian Fillinger ; openvpn- >> de...@lists.sourceforge.net >> Subject: Re: [Openvpn-devel] [PATCH] Replace deprecated mbedtls DRBG >> update function

Re: [Openvpn-devel] [PATCH v3] Implement --client-crresponse script options and plugin interface

2021-08-10 Thread Antonio Quartulli
Hi, On 18/05/2021 14:26, Arne Schwabe wrote: > This is allows scripts and pluginsto parse/react to a CR_RESPONSE message > > Patch V2: doc fixes, do not put script under ENABLE_PLUGIN > Patch V3: rebase > > Signed-off-by: Arne Schwabe > --- > doc/man-sections/script-options.rst | 28 ++

Re: [Openvpn-devel] [PATCH v3] Add example script demonstrating TOTP via auth-pending

2021-08-10 Thread Antonio Quartulli
Hi, On 02/08/2021 11:52, Arne Schwabe wrote: > Signed-off-by: Arne Schwabe > > Patch v3: Some minor cleanups in the script (rename CNs, add more comments) > > Signed-off-by: Arne Schwabe Other than the small fix reported by tincantech, this patch has already been ACK'd by David in a previous

Re: [Openvpn-devel] [PATCH] Replace deprecated mbedtls DRBG update function

2021-08-10 Thread Arne Schwabe
Am 10.08.21 um 08:16 schrieb Max Fillinger: > The function mbedtls_ctr_drbg_update is deprecated as of mbedtls 2.16 > and is superseded by mbedtls_ctr_drbg_update_ret, which returns an error > code. This commit replaces the call to the deprecated function with the > new one and logs a warning in ca

Re: [Openvpn-devel] [PATCH] Replace deprecated mbedtls DRBG update function

2021-08-10 Thread Maximilian Fillinger
> Normally we have patch v2 here and also a patch v2 in the subject (use > -v 2 when doing git format-patch) but for this small patch it is not a > problem. I'll keep it in mind for next time! > Apart from the fact that we might want to abort (M_FATAL) if this fails > instead basically ignoring t

Re: [Openvpn-devel] [PATCH] Replace deprecated mbedtls DRBG update function

2021-08-10 Thread Antonio Quartulli
On 10/08/2021 14:51, Maximilian Fillinger wrote: >> Normally we have patch v2 here and also a patch v2 in the subject (use >> -v 2 when doing git format-patch) but for this small patch it is not a >> problem. > > I'll keep it in mind for next time! > >> Apart from the fact that we might want to a