On 10/08/2021 14:51, Maximilian Fillinger wrote: >> Normally we have patch v2 here and also a patch v2 in the subject (use >> -v 2 when doing git format-patch) but for this small patch it is not a >> problem. > > I'll keep it in mind for next time! > >> Apart from the fact that we might want to abort (M_FATAL) if this fails >> instead basically ignoring the error and just log it, the change is >> fine. Considering the return status was ignored before, this patch is >> otherwise good. But failing also does not have any really bad impact... > > I was thinking about making it fatal, but there's another place where > personalizing random can fail that also only gives a warning. So that's what > I went with. (I wouldn't be opposed to making them both fatal, though.) >
IMHO it's ok to keep WARN for now because, like pointed out, other parts of the code path just warn in case of issues. Just a few line above Max's change there is another failure treated with a WARN only. Therefore I'd stick to WARN unless a complete revamp is performed on the entire codepath. Regards, -- Antonio Quartulli _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
