> Normally we have patch v2 here and also a patch v2 in the subject (use
> -v 2 when doing git format-patch) but for this small patch it is not a
> problem.

I'll keep it in mind for next time!

> Apart from the fact that we might want to abort (M_FATAL) if this fails
> instead basically ignoring the error and just log it, the change is
> fine. Considering the return status was ignored before, this patch is
> otherwise good. But failing also does not have any really bad impact...

I was thinking about making it fatal, but there's another place where
personalizing random can fail that also only gives a warning. So that's what
I went with. (I wouldn't be opposed to making them both fatal, though.)

Anyway, thanks for the ACK!

_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to