ACK.
Based on:
- after this patch, the compat-lz4.c and compat-lz4.h files exactly match
the lz4.c/lz4.h files from the upstream repo, tag 1.7.5, with the
modifications done by our tool (needed to fit the "compat" conditional
building)
- with 1.7.5, we can have LZ4_versionString() now [
Hi,
returning to this patchset about printing the LZ4 library version...
On Sat, Sep 23, 2017 at 10:52:16AM +0200, Simon Matter wrote:
> > On Thu, Sep 07, 2017 at 10:40:21PM +0200, Simon Matter wrote:
> >> While we are at it, I found it useful to see the used LZ4 version at
> >> runtime as it is
Hi,
On Sat, Jul 01, 2017 at 02:53:58PM +0200, Steffan Karger wrote:
> Before refactoring this function, add tests to verify the new
> implementation.
>
> While writing the tests, it became clear that this function is not
> behaving very well. We'll fix that in follow-up commits.
>
> Signed-off-
Your patch has been applied to the master and release/2.4 branch.
commit 6b5dbf6c8da0ff82fa1dca4eb4665be0a4fe31d3 (master)
commit 7e047e93f5d5317be1d491c6269524cee9a07085 (release/2.4)
Author: James Bottomley
Date: Sun Oct 29 15:34:48 2017 +
autoconf: Fix engine checks for openssl 1.1
Hi,
On Wed, Nov 01, 2017 at 07:24:02PM +0100, Steffan Karger wrote:
> This looks like it should use our user query wrappers from (e.g.)
> console.h. David, you're the expert here, what should James use to
> query for passwords?
The mechanics are "query_user_...()", most conveniently
/**
* A pl
Your patch has been applied to the master and release/2.4 branch.
commit 4ac769fb848619dcb39589af29302d8c2d698258 (master)
commit ff857aaa3bb1b496aee042a2af2830350abc5d69 (release/2.4)
Author: Jeremie Courreges-Anglas
Date: Thu Oct 5 01:43:33 2017 +0200
Cast time_t to long long in order to
ACK, thanks. Reviewed by "staring at the code" (changes are only what it
says on the tin), compiling with clang and gcc (no format related warnings),
and running tests, of course :-)
I'm a bit undecided whether this should go to release/2.4 as well, as it
is "refactoring" and our general policy i
Your patch has been applied to the master and release/2.4 branch.
commit d2a7415f265aea5e0f04d80e48af506e153ba0f4 (master)
commit c6af7006219ec03ece4545355251e79b47d56e8c (release/2.4)
Author: Simon Rozman
Date: Thu Oct 12 12:34:48 2017 +0200
Fix local #include to use quoted form
Ack
Applied with the change proposed by David (removing the last sentence).
Thanks.
Your patch has been applied to the master and release/2.4 branch.
commit a294cd65f6c61d41e1b7584b07295aba73aeb4cb (master)
commit a255c3b2a77b282fcf1a8cba9d7ec34d48bfd0ed (release/2.4)
Author: Simon Rozman
Date: We
ACK.
(This is a bit weird, David has obviously ACKed it, but the ACK never
made it to the list - Simon followed up on the ACK, and References:
points to tophemmelig.net, so I know it was David... - but anyway,
since this is an obviously-correct documentation fix, I dare to just
ACK it myself ;-)
Your patch has been applied to the master and release/2.4 branch.
commit 2f7b59196f55d62386cbcb2a889381e91e6c5148 (master)
commit 7e36553aa6f0c5ca1944025e0bd09aacb38a41cb (release/2.4)
Author: Simon Rozman
Date: Fri Oct 13 11:50:08 2017 +0200
Uniform swprintf() across MinGW and MSVC compil
ACK. This is something I can understand, without knowing MSVC :-)
Your patch has been applied to the master and release/2.4 branch.
commit 289ba682c70f9ea801fabca297115409acc437c9 (master)
commit 6d4d62859db9bbe9b979d485fb7539a56a25212c (release/2.4)
Author: Simon Rozman
Date: Wed Oct 11 01:11
On Sat, Nov 4, 2017 at 1:58 PM, Gert Doering wrote:
> Hi,
>
> On Wed, Nov 01, 2017 at 07:24:02PM +0100, Steffan Karger wrote:
> > This looks like it should use our user query wrappers from (e.g.)
> > console.h. David, you're the expert here, what should James use to
> > query for passwords?
>
>
Hi Simon,
On Thu, Nov 2, 2017 at 11:26 PM, Selva wrote:
> Hi Simon,
>
> On Thu, Nov 2, 2017 at 3:21 PM, Simon Rozman wrote:
>
>> While openvpn.exe can run multiple concurrent processes, openvpnserv.exe
>> is usually only one single globally unique running process.
>>
>> This patch extends openv
ACK.
Arguably I have no idea about systemd, but documentation is generally
welcome, and "how to use openvpn in a systemd environment" is something
we better document :-) - since there is no code change involved, I do not
need to verify if this actually correct, but I assume that David knows
better
From: Steffan Karger
Before refactoring this function, add tests to verify the new
implementation.
While writing the tests, it became clear that this function is not
behaving very well. We'll fix that in follow-up commits.
Signed-off-by: Steffan Karger
---
v2: add assert_buf_equals_str macro,
16 matches
Mail list logo
