Hi Simon,
On Thu, Nov 2, 2017 at 11:26 PM, Selva <selva.n...@gmail.com> wrote:
> Hi Simon,
>
> On Thu, Nov 2, 2017 at 3:21 PM, Simon Rozman <si...@rozman.si> wrote:
>
>> While openvpn.exe can run multiple concurrent processes, openvpnserv.exe
>> is usually only one single globally unique running process.
>>
>> This patch extends openvpnserv.exe to support multiple service instances
>> in parallel allowing side-by-side OpenVPN installations.
>>
>
> That was fast. On a quick glance, looks good but the patch does not apply
> on current master. Did you base it on some of your recent patches not
> all of which are yet merged? Looks like the contexts in common.c and
> interactive.c do not match so the patch fails.
>
Even after the merge of pending patches this does not apply.
openvpn_sntprintf(ovpn_pipe_name, _countof(ovpn_pipe_name),
> - TEXT("\\\\.\\pipe\\" PACKAGE "\\service_%lu"),
> GetCurrentThreadId());
>
This shows the patch is based on a private branch. Currently the client
pipe is not named after
PACKAGE as this snippet would imply.
> + TEXT("\\\\.\\pipe\\%s\\service_%lu"),
> service_instance, GetCurrentThreadId());
> ovpn_pipe = CreateNamedPipe(ovpn_pipe_name,
> PIPE_ACCESS_DUPLEX |
> FILE_FLAG_FIRST_PIPE_INSTANCE | FILE_FLAG_OVERLAPPED,
> PIPE_TYPE_MESSAGE | PIPE_READMODE_MESSAGE
> | PIPE_WAIT, 1, 128, 128, 0, NULL);
Could you please send a v2 rebased to current master?
Thanks,
Selva
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
