Hi, On Sat, Jul 01, 2017 at 02:53:58PM +0200, Steffan Karger wrote: > Before refactoring this function, add tests to verify the new > implementation. > > While writing the tests, it became clear that this function is not > behaving very well. We'll fix that in follow-up commits. > > Signed-off-by: Steffan Karger <steffan.kar...@fox-it.com> > --- > tests/unit_tests/openvpn/test_buffer.c | 181 > ++++++++++++++++++++++++++++++++-
Working on my heap of old stuff, I've decided to ACK this ("test code
is good!") but it doesn't pass - with just 1/5 applied to master, the
test code fails:
[==========] Running 9 test(s).
[ RUN ] test_buffer_strprefix
[ OK ] test_buffer_strprefix
[ RUN ] test_buffer_list_full
[ OK ] test_buffer_list_full
[ RUN ] test_buffer_list_aggregate_separator_empty
[ OK ] test_buffer_list_aggregate_separator_empty
[ RUN ] test_buffer_list_aggregate_separator_noop
[ OK ] test_buffer_list_aggregate_separator_noop
[ RUN ] test_buffer_list_aggregate_separator_two
[ OK ] test_buffer_list_aggregate_separator_two
[ RUN ] test_buffer_list_aggregate_separator_all
[ OK ] test_buffer_list_aggregate_separator_all
[ RUN ] test_buffer_list_aggregate_separator_nosep
[ ERROR ] --- "onetwothreeee," != "onetwothree"
[ LINE ] --- test_buffer.c:169: error: Failure!
[ FAILED ] test_buffer_list_aggregate_separator_nosep
... so, waiting for a v2...
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
