MinGW's snwprintf() is a replacement for ISO C's swprintf() used by
MSVC. MSVC also provides _snwprintf(), however using it leads to
unportable code.
After a discussion with Selva Nair on devel mailing list, an agreement
was reached to use swprintf() for MSVC builds.
This patch uniforms snwprintf
Your patch has been applied to the master and release/2.4 branch.
commit 55305a2fc66a768cbbf152da9092400590504574 (master)
commit 0e91a2ddb79f34a8cb361cda2f4d4a1df39d3c18 (release/2.4)
Author: Simon Rozman
Date: Wed Oct 11 01:11:20 2017 +0200
RtlIpv6AddressToStringW() and RtlIpv4AddressToS
Dynamically locating API function addresses at run-time using
GetProcAddress() was a leftover from the early days of the interactive
service development. It was required before `NTDDI_VERSION` was raised
from Windows XP to Windows Vista.
After NTDDI_VERSION API level was raised to NTDDI_VISTA, the
This is a follow-up (or better worded: a replacement) patch for "[PATCH
01/13] snwprintf() => _snwprintf()".
I have taken into consideration all Selva's recommendations.
Best regards,
Simon
> -Original Message-
> From: Simon Rozman [mailto:si...@rozman.si]
> Sent: Thursday, October 12, 2
Hi,
Thank you for your feedback.
Based on it, I have sent a new patch "[PATCH] Uniform snwprintf() across MinGW
and MSVC compilers", that supersedes this one.
Best regards,
Simon
From: Selva [mailto:selva.n...@gmail.com]
Sent: Wednesday, October 11, 2017 4:32 PM
To: Simon Rozman
Cc: o
Hi Simon,
On 12/10/17 16:09, Simon Rozman wrote:
> This is a follow-up (or better worded: a replacement) patch for "[PATCH
> 01/13] snwprintf() => _snwprintf()".
>
> I have taken into consideration all Selva's recommendations.
>
In case you weren't, you can write comments like the one above rig
Hi Simon,
Really great to see all your patches! Thanks a lot!
On 11/10/17 15:45, si...@rozman.si wrote:
> From: Simon Rozman
>
> Authentication tokens are security enhancement eliminating client
> need to cache passwords, and are indispensable at two factor
> authentication methods, such as
Hi,
> Really great to see all your patches! Thanks a lot!
I have a strong motivation for it, as I am planning some future changes for
openvpnserv.exe. It would help me to keep in sync with official OpenVPN source
base if the majority of base issues MSVC has with OpenVPN sources is resolved
fi
Hi,
> ACK. This is obviously correct. And I double checked it on a running
> OpenVPN server with the management interface enable.
I did. It works! :)
If you have an idea, how to extend management-notes.txt documentation with
expected management interface response, I'd gladly document it too.
Hi,
any opinion regarding this diff?
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
signature.asc
Description: PGP signature
--
Check out the vibrant tech community on one of the world'
.h include files from the same folder or addressed relatively to the
same folder should be #included using quoted form in MSVC. The angled
form is reserved for include files from folders specified using /I
path.
Using angled form, MSVC fails to locate local #include file, unless
current folder is
Hi Jeremie,
On Thu, Oct 12, 2017 at 12:11:13PM +0200, Jeremie Courreges-Anglas wrote:
> any opinion regarding this diff?
Quickly skimmed over it, looked reasonable. Lack of time... (so, thanks
for the reminder).
gert
--
USENET is *not* the non-clickable part of WWW!
Hi,
I have fixed msvc-*.bat files in the project root too now. So now IDE can be
launched from command line, as well as MSVC building works from command line
now. I see you have forked OpenVPN repository on GitHub and applied my patches,
so you might be interested in this one too. Let me kno
Hi,
On Thu, Oct 12, 2017 at 6:34 AM, Simon Rozman wrote:
> .h include files from the same folder or addressed relatively to the
> same folder should be #included using quoted form in MSVC. The angled
> form is reserved for include files from folders specified using /I
> path.
>
> Using angled fo
Hi,
On Tue, Oct 10, 2017 at 7:11 PM, wrote:
> From: Simon Rozman
>
> 1. The project file was created from scratch.
> 2. XML nodes were reordered to match old project order for easier diff-ing.
> 3. All non-essential settings reset to MSVC defaults.
> 4. .h/.c file list updated.
> 5. Missing /I
Hi,
On Thu, Oct 12, 2017 at 11:56:23AM -0400, Selva wrote:
> Though we do not have a patch allocation policy, as I have responded to 1
> to 5 I might have become the de-facto reviewer of this patch set.
I had hoped that you'll review this, as you *are* the one who understands
windows best :-)
>
Hi,
For book keeping its easier if version 2 of a patch is sent to the same
thread as
the original (e.g., use --in-reply-to: in git send-email) and
[PATCH v2 01/13]
in header.
Anyway, this one is v2 of [PATCH 01/13]
https://www.mail-archive.com/openvpn-devel@lists.sourceforge
.net/msg15583.html
Hi,
Note to self: this is v2 of [PATCH 05/13]
https://www.mail-archive.com/openvpn-devel@lists.sourceforge
.net/msg15589.html
On Thu, Oct 12, 2017 at 4:07 AM, Simon Rozman wrote:
> Dynamically locating API function addresses at run-time using
> GetProcAddress() was a leftover from the early day
Hi,
> For book keeping its easier if version 2 of a patch is sent to the same
> thread
> as the original (e.g., use --in-reply-to: in git send-email) and
> [PATCH
> v2 01/13] in header.
Thank you, I'll learn the team-play. Please have patience with me. :)
> > On Thu, Oct 12, 2017 at 3:24 AM,
19 matches
Mail list logo
