Hi, > For book keeping its easier if version 2 of a patch is sent to the same > thread > as the original (e.g., use --in-reply-to: <msgid> in git send-email) and > [PATCH > v2 01/13] in header.
Thank you, I'll learn the team-play. Please have patience with me. :) > > On Thu, Oct 12, 2017 at 3:24 AM, Simon Rozman <si...@rozman.si> wrote: > > MinGW's snwprintf() is a replacement for ISO C's swprintf() used by MSVC. > > A confusing statement as MinGW too has 'swprintf' and my suggestion was > to just use 'swprintf' both for mingw and MSVC. Then neither build would > depend on non-standard variants. Actually, the statement would have been correct if you change "MSVC" to "MSVC2017". > As said above, I would have replaced all _snwprintf and snwprintf by > swprintf > and avoided the #define. That has the added advantage that mingw builds > also will no longer depend on the non-standard snwprintf. Are you sure MinGW supports swprintf() in an ISO C conformant way? People all over the web complain about MinGW's non-ISO C conformant swprintf() declaration being a legacy of VC 6.0 runtime library used: https://stackoverflow.com/questions/35072373/swprintf-declaration-mismatch As said before, I am not familiar with MinGW. I read OpenVPN has a patched version of it. Perhaps you moved to a more recent VC runtime library meanwhile. If we change _snwprintf/snwprintf() to swprintf() as you suggested, I am afraid OpenVPN would not compile on MinGW anymore without #define tweaks. But, this time MinGW will need them, not MSVC*2017*. Selva, if you can confirm that swprintf() really works on OpenVPN's distribution of MinGW in an ISO C conformant way, I'll gladly use it. I can prepare a patch for you if you can give it a try. Best regards, Simon
smime.p7s
Description: S/MIME cryptographic signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
