Hi,

On Thu, Oct 12, 2017 at 6:34 AM, Simon Rozman <si...@rozman.si> wrote:

> .h include files from the same folder or addressed relatively to the
> same folder should be #included using quoted form in MSVC. The angled
> form is reserved for include files from folders specified using /I
> path.
>
> Using angled form, MSVC fails to locate local #include file, unless
> current folder is added to the include search path: /I .
> ---
>  src/openvpnserv/common.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/src/openvpnserv/common.c b/src/openvpnserv/common.c
> index 0c9098f..e77d7ab 100644
> --- a/src/openvpnserv/common.c
> +++ b/src/openvpnserv/common.c
> @@ -21,8 +21,9 @@
>   *  51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
>   */
>
> -#include <service.h>
> -#include <validate.h>
> +#include "service.h"
> +#include "validate.h"
> +
>  /*
>   * These are necessary due to certain buggy implementations of
> (v)snprintf,
>   * that don't guarantee null termination for size > 0.
>

In mingw builds it works either way as our Makefile includes -I ./ as the
first search path.
But conventionally quoted path is the right thing to use here.

ACK.

Selva
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to