On 11-10-18 13:56, Gert Doering wrote:
> On Thu, Oct 11, 2018 at 01:52:37PM +0200, Steffan Karger wrote:
>>> I know that Steffan likes using size_t for "things that have a size"
>>> but I find it a bit questionable here :-)
>>
>> So the underlying problem is that "further down" used int to store
>>
Hi,
On Thu, Oct 11, 2018 at 01:52:37PM +0200, Steffan Karger wrote:
> > I know that Steffan likes using size_t for "things that have a size"
> > but I find it a bit questionable here :-)
>
> So the underlying problem is that "further down" used int to store
> sizes, but since that just is the way
Hi,
On 11-10-18 13:23, Gert Doering wrote:
> On Thu, Oct 11, 2018 at 01:40:16PM +0300, Lev Stipakov wrote:
>>> Since crypto_overhead and crypto_max_overhead() are both size_t, and
>>> frame_add_to_extra_frame() is declared to take an "unsigned int" now,
>>> this cast should not be necessary.
>>
>>
Hi,
On Thu, Oct 11, 2018 at 01:40:16PM +0300, Lev Stipakov wrote:
> > Since crypto_overhead and crypto_max_overhead() are both size_t, and
> > frame_add_to_extra_frame() is declared to take an "unsigned int" now,
> > this cast should not be necessary.
>
>
> Visual Studio disagrees. Without expli
Hi,
> Since crypto_overhead and crypto_max_overhead() are both size_t, and
> frame_add_to_extra_frame() is declared to take an "unsigned int" now,
> this cast should not be necessary.
Visual Studio disagrees. Without explicit cast I got
> warning C4267: 'function': conversion from 'size_t' to
Hi,
On Wed, Oct 10, 2018 at 03:26:17PM +0300, Lev Stipakov wrote:
> crypto_overhead += kt->hmac_length;
>
> -frame_add_to_extra_frame(frame, crypto_overhead);
> +frame_add_to_extra_frame(frame, (unsigned int) crypto_overhead);
Even if Arne already ACKed it, I have reservations abou
Am 10.10.18 um 14:26 schrieb Lev Stipakov:
> From: Lev Stipakov
>
> In Visual Studio when unary minus is applied to unsigned,
> result is still unsigned. This means that when we use result
> as function formal parameter, we pass incorrect value.
>
> Fix by introducing frame_remove_from_extra_fra
