Hi, On Thu, Oct 11, 2018 at 01:52:37PM +0200, Steffan Karger wrote: > > I know that Steffan likes using size_t for "things that have a size" > > but I find it a bit questionable here :-) > > So the underlying problem is that "further down" used int to store > sizes, but since that just is the way it is and we shouldn't pull in > refactoring the code base for each small change, I would say either make > both 'int', or make both 'size_t', but without changing the types of > struct frame itself. I of course prefer the latter ;-)
Adding or substracting a size_t from frame->extra_frame (which is an int)
will quite likely cause the same warning again... so I'd argue for
"make it all int, and be happy with it foreverafter" :-)
(And possibly revisit our use of size_t... *cough*)
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
