Hi, On Wed, Oct 10, 2018 at 03:26:17PM +0300, Lev Stipakov wrote: > crypto_overhead += kt->hmac_length; > > - frame_add_to_extra_frame(frame, crypto_overhead); > + frame_add_to_extra_frame(frame, (unsigned int) crypto_overhead);
Even if Arne already ACKed it, I have reservations about this.
Since crypto_overhead and crypto_max_overhead() are both size_t, and
frame_add_to_extra_frame() is declared to take an "unsigned int" now,
this cast should not be necessary.
Unnecessary casts hide bugs and hurt my eyes...
> static inline void
> +frame_remove_from_extra_frame(struct frame *frame, const unsigned int
> increment)
> +{
> + frame->extra_frame -= increment;
> +}
Maybe call the negative increment a "decrement" instead?
> @@ -3509,7 +3509,7 @@ calc_options_string_link_mtu(const struct options *o,
> const struct frame *frame)
> struct key_type fake_kt;
> init_key_type(&fake_kt, o->ciphername, o->authname, o->keysize, true,
> false);
> - frame_add_to_extra_frame(&fake_frame, -(crypto_max_overhead()));
> + frame_remove_from_extra_frame(&fake_frame, (unsigned int)
> crypto_max_overhead());
Same here wrt (unsigned int) cast.
Otherwise indeed much clearer.
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
