Re: [Openvpn-devel] [PATCH] Remove deprecated plugin functions from code samples

On 30/06/2018 23:08, Greg Cox wrote: > > On Sat, Jun 30, 2018 at 5:49 PM, Antonio Quartulli > wrote: > > I'd remove the last paragraph and the greetings from the commit message. > But this might be done at commit time. > > > ​It was unclear how to handle "expl

Re: [Openvpn-devel] [PATCH] Remove deprecated plugin functions from code samples

On 01/07/18 05:08, Greg Cox wrote: > On Sat, Jun 30, 2018 at 5:49 PM, Antonio Quartulli wrote: > >> I'd remove the last paragraph and the greetings from the commit message. >> But this might be done at commit time. >> > > ​It was unclear how to handle "explain what I'm wanting" in one mail. > S

Re: [Openvpn-devel] [PATCH] Remove deprecated plugin functions from code samples

Minggu, 01 Juli 2018, Yovie Ramadhan menulis: > > > Minggu, 01 Juli 2018, Antonio Quartulli menulis: > >> Hi, >> >> On 01/07/18 00:58, Greg Cox wrote: >> > While writing up a plugin, I found that the sample plugin code was using >> > openvpn_plugin_open_v1. Since that and openvpn_plugin_func_v1

Re: [Openvpn-devel] [PATCH] Remove deprecated plugin functions from code samples

Minggu, 01 Juli 2018, Antonio Quartulli menulis: > Hi, > > On 01/07/18 00:58, Greg Cox wrote: > > While writing up a plugin, I found that the sample plugin code was using > > openvpn_plugin_open_v1. Since that and openvpn_plugin_func_v1 are listed > > as 'deprecated' in openvpn-plugin.h, it made

Re: [Openvpn-devel] [PATCH] Remove deprecated plugin functions from code samples

On Sat, Jun 30, 2018 at 5:49 PM, Antonio Quartulli wrote: > I'd remove the last paragraph and the greetings from the commit message. > But this might be done at commit time. > ​It was unclear how to handle "explain what I'm wanting" in one mail. Sorry. ​ > did you concatenate two patches? or wh

Re: [Openvpn-devel] [PATCH] Remove deprecated plugin functions from code samples

Hi, On Sun, Jul 01, 2018 at 01:49:26AM +0800, Antonio Quartulli wrote: [..] > did you concatenate two patches? or what happened? It seems that the > part after this is not recognised as proper patch. If the patch gets an ACK otherwise, I can (usually) fix this on commit. gert -- "If was one t

Re: [Openvpn-devel] [PATCH] Remove deprecated plugin functions from code samples

Hi, On 01/07/18 00:58, Greg Cox wrote: > While writing up a plugin, I found that the sample plugin code was using > openvpn_plugin_open_v1. Since that and openvpn_plugin_func_v1 are listed > as 'deprecated' in openvpn-plugin.h, it made sense to me that you shouldn't > list those functions as samp