On 01/07/18 05:08, Greg Cox wrote: > On Sat, Jun 30, 2018 at 5:49 PM, Antonio Quartulli <a...@unstable.cc> wrote: > >> I'd remove the last paragraph and the greetings from the commit message. >> But this might be done at commit time. >> > > βIt was unclear how to handle "explain what I'm wanting" in one mail. > Sorry. > β
When creating a patch with "git-format-patch" there are three dashes at
the end of the commit message ("---") - anything you write after that
will be dropped when merging the patch, thus that's where you can write
what you want to explain :)
>
>> did you concatenate two patches? or what happened? It seems that the
>> part after this is not recognised as proper patch.
>>
>
> I think I dropped a few lines from `git format-patch HEAD~1 --stdout`β on
> accident. Take two:
>
Thanks. Normally "git format-patch" + "git send-email" take care of all
the details for you (without --stdout, but by just using the produced
file), so to ensure that the patch lands properly formatted.
You can try next time :)
Cheers,
--
Antonio Quartulli
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
