On 30/06/2018 23:08, Greg Cox wrote:
> 
> On Sat, Jun 30, 2018 at 5:49 PM, Antonio Quartulli <a...@unstable.cc
> <mailto:a...@unstable.cc>> wrote:
> 
>     I'd remove the last paragraph and the greetings from the commit message.
>     But this might be done at commit time.
> 
> 
> ​It was unclear how to handle "explain what I'm wanting" in one mail.  Sorry.
> ​
> 
>     did you concatenate two patches? or what happened? It seems that the
>     part after this is not recognised as proper patch.
> 
>  
> I think I dropped a few lines from `git format-patch HEAD~1 --stdout`​ on
> accident.  Take two:
> 

Hi Greg,

Sorry for the way too long response time here.  But on the plus side, I'm
looking into this now - and will follow this one up more closely.

Your "Take two" didn't work, as the patch got mangled by GMail.  And also your
initial patch was mangled too.

I usually walk the extra mile to sort this out when patches has been lingering
for so long.  But in this case, the damage might add additional errors if I
try to fix them manually.  Copy-paste of mails into mail clients often
corrupts patches in subtle ways, and in particular when graphical mail clients
- including webmails.

The alternative is to either submit the patch as an attachment, or use the
more preferred 'git send-email' approach where it will connect to your SMTP
server of your preference and send the patch properly formatted.


-- 
kind regards,

David Sommerseth
OpenVPN Inc


Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to