Re: [Openvpn-devel] [PATCH] Wrap openvpn_swprintf into Windows define

2018-10-24 Thread Selva Nair
Hi, On Wed, Oct 24, 2018 at 9:00 AM David Sommerseth wrote: > > On 24/10/18 14:39, Selva Nair wrote: > > On Wed, Oct 24, 2018 at 6:23 AM Antonio Quartulli wrote: > >> > >> Hi, > >> > > > > > > Also there is a misplaced and mismatched comment added to > > buffer.c that says > > > > +/* vs

Re: [Openvpn-devel] [PATCH] Wrap openvpn_swprintf into Windows define

2018-10-24 Thread David Sommerseth
On 24/10/18 14:39, Selva Nair wrote: > On Wed, Oct 24, 2018 at 6:23 AM Antonio Quartulli wrote: >> >> Hi, >> >> On 23/10/18 22:51, Lev Stipakov wrote: >>> From: Lev Stipakov >>> >>> Commit 43a5a4f3b4e411419639c195fee8a76495fdc88e added >>> vswprintf() call which turned to me missing in OpenBSD 4.

Re: [Openvpn-devel] [PATCH] Wrap openvpn_swprintf into Windows define

2018-10-24 Thread Selva Nair
On Wed, Oct 24, 2018 at 6:23 AM Antonio Quartulli wrote: > > Hi, > > On 23/10/18 22:51, Lev Stipakov wrote: > > From: Lev Stipakov > > > > Commit 43a5a4f3b4e411419639c195fee8a76495fdc88e added > > vswprintf() call which turned to me missing in OpenBSD 4.9. > > > > Since that call is inside openvp

Re: [Openvpn-devel] [PATCH] Wrap openvpn_swprintf into Windows define

2018-10-24 Thread Antonio Quartulli
Hi, On 23/10/18 22:51, Lev Stipakov wrote: > From: Lev Stipakov > > Commit 43a5a4f3b4e411419639c195fee8a76495fdc88e added > vswprintf() call which turned to me missing in OpenBSD 4.9. > > Since that call is inside openvpn_swprintf() function which > is only used by Windows, wrap that function i

[Openvpn-devel] [PATCH] Wrap openvpn_swprintf into Windows define

2018-10-23 Thread Lev Stipakov
From: Lev Stipakov Commit 43a5a4f3b4e411419639c195fee8a76495fdc88e added vswprintf() call which turned to me missing in OpenBSD 4.9. Since that call is inside openvpn_swprintf() function which is only used by Windows, wrap that function info #ifdef _WIN32. Signed-off-by: Lev Stipakov --- src/