[Openvpn-devel] [XS] Change in openvpn[master]: Fix check_addr_clash argument order

2024-09-11 Thread ralf_lici (Code Review)
Attention is currently required from: plaisthos. ralf_lici has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/737?usp=email ) Change subject: Fix check_addr_clash argument order .. Patch Set 1: (1 com

[Openvpn-devel] [XS] Change in openvpn[master]: Fix check_addr_clash argument order

2024-09-11 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos, ralf_lici. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/737?usp=email ) Change subject: Fix check_addr_clash argument order .. Patch

[Openvpn-devel] [XS] Change in openvpn[master]: GHA: Update dependency Mbed-TLS/mbedtls to v3.6.1

2024-09-11 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/741?usp=email ) Change subject: GHA: Update dependency Mbed-TLS/mbedtls to v3.6.1 .. GHA: Update dependency Mbed-TLS/mbedtls to v3.6.1 Requires submodule

[Openvpn-devel] [XS] Change in openvpn[master]: GHA: Update dependency Mbed-TLS/mbedtls to v3.6.1

2024-09-11 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/741?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by plaisthos Change subject: GHA: Update dependency Mbed-TLS/mbedtls to v3.6.1 .

[Openvpn-devel] [PATCH applied] Re: GHA: Update dependency Mbed-TLS/mbedtls to v3.6.1

2024-09-11 Thread Gert Doering
GHA says "this builds fine", and so we apply it :-) (And the worries that 3.6.x would break with TLS 1.3 due to missing key-exporter are alleviated by our mbedtls builds disabling 1.3 anyway, due to missing key-exporter...) Your patch has been applied to the master branch. commit f4d7cec855aea3c

[Openvpn-devel] [PATCH v1] GHA: Update dependency Mbed-TLS/mbedtls to v3.6.1

2024-09-11 Thread Frank Lichtenheld
Requires submodule checkout. Change-Id: I86ceceb4e1c716b33c6c6ec8853eca0fb4b394f1 Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/ope

[Openvpn-devel] [PATCH v1] GHA: Update dependency Mbed-TLS/mbedtls to v3.6.1

2024-09-11 Thread Gert Doering
From: Frank Lichtenheld Requires submodule checkout. Change-Id: I86ceceb4e1c716b33c6c6ec8853eca0fb4b394f1 Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https:

[Openvpn-devel] [XS] Change in openvpn[master]: GHA: Update dependency Mbed-TLS/mbedtls to v3.6.1

2024-09-11 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/741?usp=email ) Change subject: GHA: Update dependency Mbed-TLS/mbedtls to v3.6.1 .. Pat

[Openvpn-devel] [XS] Change in openvpn[master]: GHA: Update dependency Mbed-TLS/mbedtls to v3.6.1

2024-09-11 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/741?usp=email ) Change subject: GHA: Update dependency Mbed-TLS/mbedtls to v3.6.1 .. Pat

[Openvpn-devel] [S] Change in openvpn[master]: GHA: Enable t_server_null tests

2024-09-11 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/743?usp=email to review the following change. Change subject: GHA: Enable t_server_null tests

[Openvpn-devel] [L] Change in openvpn[master]: Support CIDR on options and extend netbits usage

2024-09-11 Thread ralf_lici (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ralf_lici has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/739?usp=email ) Change subject: Support CIDR on options and extend netbits usage ..

[Openvpn-devel] [L] Change in openvpn[master]: Support CIDR on options and extend netbits usage

2024-09-11 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos, ralf_lici. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/739?usp=email ) Change subject: Support CIDR on options and extend netbits usage ..

[Openvpn-devel] [XS] Change in openvpn[master]: GHA: Update dependency Mbed-TLS/mbedtls to v3.6.1

2024-09-11 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/741?usp=email ) Change subject: GHA: Update dependency Mbed-TLS/mbedtls to v3.6.1 .. Pat

[Openvpn-devel] [L] Change in openvpn[master]: Support CIDR on options and extend netbits usage

2024-09-11 Thread ralf_lici (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ralf_lici has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/739?usp=email ) Change subject: Support CIDR on options and extend netbits usage ..

[Openvpn-devel] [S] Change in openvpn[master]: Cache mbed TLS dependency and build latest 2.x mbed TLS as well

2024-09-11 Thread plaisthos (Code Review)
plaisthos has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/455?usp=email ) Change subject: Cache mbed TLS dependency and build latest 2.x mbed TLS as well .. Abandoned -- To view, visit http://gerrit.openvpn.n

[Openvpn-devel] [M] Change in openvpn[master]: dco-win: factor out getting dco version info own function

2024-09-11 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/733?usp=email ) Change subject: dco-win: factor out getting dco version info own function ..

[Openvpn-devel] [L] Change in openvpn[master]: Support CIDR on options and extend netbits usage

2024-09-11 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos, ralf_lici. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/739?usp=email ) Change subject: Support CIDR on options and extend netbits usage ..

[Openvpn-devel] [XS] Change in openvpn[master]: GitHub: preventing errors on GitHub Mac runner images

2024-09-11 Thread mrbff (Code Review)
mrbff has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/732?usp=email ) Change subject: GitHub: preventing errors on GitHub Mac runner images .. Abandoned Not needed anymore -- To view, visit http://gerrit.ope

[Openvpn-devel] [M] Change in openvpn[master]: Move to common backend_driver type in struct tuntap

2024-09-11 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/738?usp=email ) Change subject: Move to common backend_driver type in struct tuntap .. P

[Openvpn-devel] IRC community meeting summary

2024-09-11 Thread Johan Draaisma
Meeting summary for 11 September 2024: * *Updated: OpenVPN community meetup 2024* /Hotel recommendation added; Hotel Santo in Karlsruhe./ /Wiki coordination page:​https://community.openvpn.net/openvpn/wiki/CommunityMeetup2024

[Openvpn-devel] [S] Change in openvpn[master]: Do not stop reading from file/uri when OPENSSL_STORE_load() returns e...

2024-09-11 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/742?usp=email ) Change subject: Do not stop reading from file/uri when OPENSSL_STORE_load() returns error .. Do not stop reading from file/uri when OPENSS

[Openvpn-devel] [S] Change in openvpn[master]: Do not stop reading from file/uri when OPENSSL_STORE_load() returns e...

2024-09-11 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#2) to the change originally created by selvanair. ( http://gerrit.openvpn.net/c/openvpn/+/742?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by plaisthos Change subject: Do not stop reading from file/uri when OPENSSL_STORE_l

[Openvpn-devel] [PATCH applied] Re: Do not stop reading from file/uri when OPENSSL_STORE_load() returns error

2024-09-11 Thread Gert Doering
Thanks for fixing this so quickly. Now this seems to be an... interesting API to work with... :-) I do not have something really interesting set up in terms of cert files and storage, so I just did basic client side testing with OSSL 3.x (works). Your patch has been applied to the master branch

[Openvpn-devel] [S] Change in openvpn[master]: generate_auth_token: simplify code

2024-09-11 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#4) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/310?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by plaisthos Change subject: generate_auth_token: simplify code

[Openvpn-devel] [S] Change in openvpn[master]: generate_auth_token: simplify code

2024-09-11 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/310?usp=email ) Change subject: generate_auth_token: simplify code .. generate_auth_token: simplify code The previous code went through some hoops to avoi

[Openvpn-devel] [PATCH applied] Re: generate_auth_token: simplify code

2024-09-11 Thread Gert Doering
Has an ACK from the owner of the code :-) - plus full test with the server instance that does auth-tokens (including expiry + regen) and a bit of stare-at-the-code. Your patch has been applied to the master branch. commit 3c77d328911bab5169d6981fbef34e8398c5b7b7 Author: Frank Lichtenheld Date:

Re: [Openvpn-devel] [PATCH applied] Re: Static-challenge concatenation option

2024-09-11 Thread Jonathan K. Bullard
Hi, On Mon, Sep 9, 2024 at 1:11 PM Gert Doering wrote: > > Hi, > > On Mon, Sep 09, 2024 at 12:01:54PM -0400, Selva Nair wrote: > > > Is the GUI support already committed? I seem to remember seeing a PR > > > for that "weeks ago"... and someone needs to bring Tunnelblick on board. > > > > I've se

[Openvpn-devel] [PATCH v1] Do not stop reading from file/uri when OPENSSL_STORE_load() returns error

2024-09-11 Thread Gert Doering
From: Selva Nair OPENSSL_STORE_load() can error and return NULL even when the file or URI still has readable objects left. Fix by iterating until OPENSSL_STORE_eof(). Also clear such errors to avoid misleading messages printed at the end by crypto_print_openssl_errors(). Change-Id: I2bfa9ffbd17

[Openvpn-devel] [S] Change in openvpn[master]: Do not stop reading from file/uri when OPENSSL_STORE_load() returns e...

2024-09-11 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld, selvanair. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/742?usp=email ) Change subject: Do not stop reading from file/uri when OPENSSL_STORE_load() returns error

[Openvpn-devel] [S] Change in openvpn[master]: Do not stop reading from file/uri when OPENSSL_STORE_load() returns e...

2024-09-11 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld, selvanair. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/742?usp=email ) Change subject: Do not stop reading from file/uri when OPENSSL_STORE_load() returns error