Attention is currently required from: flichtenheld, plaisthos.

ralf_lici has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/739?usp=email )

Change subject: Support CIDR on options and extend netbits usage
......................................................................


Patch Set 2:

(4 comments)

Patchset:

PS2:
> Only started going through the code, so only a few comments. […]
Will do


File src/openvpn/options.c:

http://gerrit.openvpn.net/c/openvpn/+/739/comment/2609ef1b_3e2658b8 :
PS2, Line 1516:     msg(D_SHOW_PARMS, "  server_network = %s/%d", 
print_in_addr_t(o->server_network, 0, &gc), o->server_netbits);
> %u
Acknowledged


http://gerrit.openvpn.net/c/openvpn/+/739/comment/511cdb40_3a9d08f3 :
PS2, Line 1519:     msg(D_SHOW_PARMS, "  server_bridge_ip = %s/%d", 
print_in_addr_t(o->server_bridge_ip, 0, &gc), o->server_bridge_netbits);
> %u
Acknowledged


http://gerrit.openvpn.net/c/openvpn/+/739/comment/af179191_a1b280d9 :
PS2, Line 1535:     msg(D_SHOW_PARMS, "  ifconfig_pool_start = %s/%d", 
print_in_addr_t(o->ifconfig_pool_start, 0, &gc), o->ifconfig_pool_netbits);
> %u […]
So you are suggesting avoiding netbits in this case?



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/739?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Iae04ad8715e40dfc76475c2c5b9a766c9604efc9
Gerrit-Change-Number: 739
Gerrit-PatchSet: 2
Gerrit-Owner: ralf_lici <r...@mandelbit.com>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Comment-Date: Wed, 11 Sep 2024 13:26:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com>
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to