Attention is currently required from: plaisthos.

Hello plaisthos,

I'd like you to do a code review.
Please visit

    http://gerrit.openvpn.net/c/openvpn/+/743?usp=email

to review the following change.


Change subject: GHA: Enable t_server_null tests
......................................................................

GHA: Enable t_server_null tests

Change-Id: I86203b8f9a6d3cfc5e56d3ce9452af694fd11011
Signed-off-by: Frank Lichtenheld <fr...@lichtenheld.com>
---
M .github/workflows/build.yaml
1 file changed, 16 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/43/743/1

diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index 8f0a7b5..361d457 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -172,8 +172,11 @@
         run: ./configure --with-crypto-library=${{matrix.ssllib}} 
${{matrix.extraconf}} --enable-werror
       - name: make all
         run: make -j3
+      - name: configure checks
+        if: ${{ matrix.extraconf != '--disable-management' }}
+        run: echo 'RUN_SUDO="sudo -E"' >tests/t_server_null.rc
       - name: make check
-        run: make check VERBOSE=1
+        run: make -j3 check VERBOSE=1

   ubuntu-clang-asan:
     strategy:
@@ -199,8 +202,10 @@
         run: CFLAGS="-fsanitize=address,undefined -fno-sanitize-recover=all  
-fno-omit-frame-pointer -O2" CC=clang ./configure 
--with-crypto-library=${{matrix.ssllib}} --enable-werror
       - name: make all
         run: make -j3
+      - name: configure checks
+        run: echo 'RUN_SUDO="sudo -E"' >tests/t_server_null.rc
       - name: make check
-        run: make check VERBOSE=1
+        run: make -j3 check VERBOSE=1
 
   macos:
     strategy:
@@ -258,8 +263,10 @@
         run: ./configure --enable-werror ${{matrix.configureflags}} 
${{matrix.configuressllib}}
       - name: make all
         run: make -j4
+      - name: configure checks
+        run: echo 'RUN_SUDO="sudo -E"' >tests/t_server_null.rc
       - name: make check
-        run: make check VERBOSE=1
+        run: make -j4 check VERBOSE=1

   msvc:
       strategy:
@@ -369,8 +376,10 @@
         run: ./configure --with-crypto-library=openssl 
${{matrix.configureflags}} --enable-werror
       - name: make all
         run: make -j3
+      - name: configure checks
+        run: echo 'RUN_SUDO="sudo -E"' >tests/t_server_null.rc
       - name: make check
-        run: make check VERBOSE=1
+        run: make -j3 check VERBOSE=1

   mbedtls3:
     strategy:
@@ -422,5 +431,7 @@
         run: ./configure --with-crypto-library=mbedtls
       - name: make all
         run: make -j3
+      - name: configure checks
+        run: echo 'RUN_SUDO="sudo -E"' >tests/t_server_null.rc
       - name: make check
-        run: make check VERBOSE=1
+        run: make -j3 check VERBOSE=1

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/743?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I86203b8f9a6d3cfc5e56d3ce9452af694fd11011
Gerrit-Change-Number: 743
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-MessageType: newchange
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to