Attention is currently required from: flichtenheld.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/476?usp=email )
Change subject: misc: make get_auth_challenge static
..
Patch Set 2:
(1 com
Attention is currently required from: plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/460?usp=email )
The change is no longer submittable: Code-Review is unsatisfied now.
Change subject: Check PRF availability on initialisation and add
--force-tls-k
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/472?usp=email )
Change subject: buffer: add documentation for string_mod and extend related UT
..
buffer: add documentation for string_mod and extend relat
cron2 has uploaded a new patch set (#2) to the change originally created by
flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/472?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by plaisthos
Change subject: buffer: add documentation for string_mod and extend
cron2 has uploaded a new patch set (#7) to the change originally created by
plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/377?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by flichtenheld
Change subject: Fix building mbed TLS with CMake and allow specifyi
The cmake stuff, I have no idea what it is :-) - but GHA builds are fine
with it. The mbedtls_compat.h change is mostly reordering the conditions
(and at least for the mbedtls version our GHA builds test against, it
seems to do the right thing).
Your patch has been applied to the master branch.
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/377?usp=email )
Change subject: Fix building mbed TLS with CMake and allow specifying custom
directories
..
Fix building mbed TLS with CMake and allow spe
Briefly skimmed the patch (verifying that no mishap happened to the numbers),
ran "make check", passed.
Your patch has been applied to the master branch.
commit 975ef50b9cdbfec70f61b258e76fd8549d7f83d5
Author: Frank Lichtenheld
Date: Mon Dec 11 18:02:14 2023 +0100
buffer: add documentatio
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/446?usp=email )
Change subject: Remove dead list test code
..
Patch Set 2: Code-Review-2
From: Arne Schwabe
When installing mbed TLS 2.x and 3.x in parallel, it is useful to point
cmake to the version that should be used.
This fixes also building mbed TLS versions with cmake.
Change-Id: I7fd9e730e87210d2b7d090c8f9c7c6734bd7374e
Signed-off-by: Arne Schwabe
Acked-by: Frank Lichtenhe
From: Arne Schwabe
We now warn a user if the TLS 1.0 PRF is not supported by the cryptographic
library of the system. Also add the option --force-tls-key-material-export
that automatically rejects clients that do not support TLS Keying Material
Export and automatically enable it when TLS 1.0 PRF
Since I was confused what exactly string_mod does, I
added documentation and additional UTs to make it
clearer.
Change-Id: I911fb5c5fa4b41f1fc1a30c6bf8b314245f64a6e
Signed-off-by: Frank Lichtenheld
Acked-by: Arne Schwabe
---
This change was reviewed on Gerrit and approved by at least one
develo
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/465?usp=email )
Change subject: Make it more explicit and visible when pkg-config is not found
...
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/455?usp=email )
Change subject: Cache mbed TLS dependency and build latest 2.x mbed TLS as well
..
Attention is currently required from: MaxF, plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/377?usp=email )
Change subject: Fix building mbed TLS with CMake and allow specifying custom
directories
..
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/446?usp=email )
Change subject: Remove dead list test code
..
Patch Set 2: Code-Review-1
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/468?usp=email )
Change subject: test_user_pass: new UT for get_user_pass
..
Patch Set 3:
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/474?usp=email )
Change subject: test_user_pass: Check fatal errors for empty username/password
...
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/468?usp=email )
Change subject: test_user_pass: new UT for get_user_pass
..
Patch Set 3:
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/478?usp=email
to review the following change.
Change subject: tests: fork default automake test-driver
...
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/477?usp=email
to review the following change.
Change subject: tests: disable automake serial_tests
...
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/479?usp=email
to review the following change.
Change subject: forked-test-driver: Show test output always
Attention is currently required from: flichtenheld, plaisthos.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/446?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review-1 by
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/473?usp=email )
Change subject: test_user_pass: Add UTs for character filtering
..
Patch
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/475?usp=email )
Change subject: test_user_pass: add basic tests for static/dynamic challenges
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/476?usp=email )
Change subject: misc: make get_auth_challenge static
..
Patch Set 2: Cod
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/474?usp=email )
Change subject: test_user_pass: Check fatal errors for empty username/password
...
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/472?usp=email )
Change subject: buffer: add documentation for string_mod and extend related UT
...
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/468?usp=email )
Change subject: test_user_pass: new UT for get_user_pass
..
Patch Set 3:
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/468?usp=email )
Change subject: test_user_pass: new UT for get_user_pass
..
Patch Set 3:
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/465?usp=email )
Change subject: Make it more explicit and visible when pkg-config is not found
...
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/465?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review-1 by flichtenh
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/465?usp=email )
Change subject: Make it more explicit and visible when pkg-config is not found
...
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/471?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review-1 by flichtenh
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/471?usp=email )
Change subject: Add test_ssl unit test and test export of PEM to file
..
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/455?usp=email )
Change subject: Cache mbed TLS dependency and build latest 2.x mbed TLS as well
..
Attention is currently required from: plaisthos.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/455?usp=email
to look at the new patch set (#4).
Change subject: Cache mbed TLS dependency and build latest 2.x mbed TLS as well
Hey,
with DCO and possible future hardware assisted OpenVPN acceleration we
are approaching the point where 32 bit IVs are not cutting it any more.
To illustrate the problem, some back of the envelope math here:
If we want to keep the current 3600s renogotiation interval and have a
safety m
38 matches
Mail list logo
