Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/468?usp=email )
Change subject: test_user_pass: new UT for get_user_pass ...................................................................... Patch Set 3: (2 comments) File CMakeLists.txt: http://gerrit.openvpn.net/c/openvpn/+/468/comment/ced071e8_e7d892e4 : PS3, Line 625: ENVIRONMENT "srcdir=${CMAKE_CURRENT_SOURCE_DIR}/tests/unit_tests/openvpn") Why not use a define instead like add_compile_definition(${target} -DSRCDIR="${CMAKE_CURRENT_SOURCE_DIR}"? That seems less fragile then an environment variable. File tests/unit_tests/openvpn/test_user_pass.c: http://gerrit.openvpn.net/c/openvpn/+/468/comment/c4d4854d_87b23353 : PS3, Line 86: } I think we should be consistent here. Either do the (void) var; in all mocked functions or none. I would prefer not to use them if not necessary. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/468?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I193aef06912f01426dd4ac298aadfab97dd75a35 Gerrit-Change-Number: 468 Gerrit-PatchSet: 3 Gerrit-Owner: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Mon, 11 Dec 2023 14:42:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
