Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/474?usp=email )
Change subject: test_user_pass: Check fatal errors for empty username/password ...................................................................... Patch Set 2: Code-Review-1 (2 comments) Patchset: PS2: I tried to replicate the leak that is being supressed (with blanking the content of that .txt file) but cannot trigger it at least on macOS. It would be also good to actually have a comment in the unit where the supressed leak is happening. File tests/unit_tests/openvpn/input/leak_suppr.txt: http://gerrit.openvpn.net/c/openvpn/+/474/comment/cf59cf0c_68f7af73 : PS2, Line 1: leak:_assertions$ This feels unecessarily broad. Especially since we are using it on every unit test that is being run and not only on the input unit tests. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/474?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Icabc8acf75638c86c8c395e9ffecba7a7226cd97 Gerrit-Change-Number: 474 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Mon, 11 Dec 2023 14:58:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
