Acked-by: Gert Doering
"diff -w" shows that this is really "C99, early return, whitespace".
Nevertheless, full client and server tested :-) (and passes).
Your patch has been applied to the master branch.
commit 162499591d03155e853ed44c90c12771307ee0eb
Author: Arne Schwabe
Date: Mon Aug 10 16
Acked-by: Gert Doering
Reviewed again (with and without "-w"), is really "just" moving
data packet handling into its own function and getting rid of
layers of indentation...
Subjected to client and server tests (which do excercise the
"success" case quite thoroughly, but not all possible error c
Your patch has been applied to the master branch.
commit e02616d82105aeb77f8f811c94fd595ca1a96eae
Author: Arne Schwabe
Date: Tue Aug 11 13:02:48 2020 +0200
Document comp-lzo no and compress being incompatible
Acked-by: Gert Doering
Message-Id: <2020080248.3396-1-a...@rfc254
Am 11.08.20 um 11:58 schrieb Gert Doering:
> Hi,
>
> On Wed, Oct 10, 2018 at 05:29:18PM +0200, Arne Schwabe wrote:
>> Although mbed TLS does not have a TLS 1.3 API yet and we do not really
>> know how mbed TLS will handle querying for TLS 1.3 signatures, being
>> able to use the same API with Open
Most of the new compress but not v2 version do use swap operation. For
'compress lzo' the swap option is not used for backwards compatibility.
For lz4 the swap option is also not a problem since there is no version
without swap. Unfortunately, compress introduced a second stub format
with swap, con
- Extract data packet handling to its own function
- Replace two instances of
if (x) { code }
with
if (!x) return; code
- Remove extra curly braces that were used for pre C99 code style
to be able to declare variables in the middle of a block
This patch is easier to review
This is a new "samples" plugin which does not do many useful things,
besides
- show how a plugin is programmed
- how the various messages get dispatched
- how to pass back information from a client-connect/v2 plugin
- how to do async-cc plugins [not yet implemented]
the operation of the plugi
Hi,
On Wed, Oct 10, 2018 at 05:29:18PM +0200, Arne Schwabe wrote:
> Although mbed TLS does not have a TLS 1.3 API yet and we do not really
> know how mbed TLS will handle querying for TLS 1.3 signatures, being
> able to use the same API with OpenSSL and mbed TLS is a nice feature.
>
> Since mbed
Hi,
On Fri, Oct 26, 2018 at 04:48:26PM +0200, Arne Schwabe wrote:
> Am 26.10.18 um 13:31 schrieb David Sommerseth:
> > On 24/10/18 13:33, Arne Schwabe wrote:
> >> Most of the new compress but not v2 version do use swap operation. For
> >> 'compress lzo' the swap option is not used for backwards co
Hi,
On Thu, Apr 11, 2019 at 12:07:27PM +1000, Eric Thorpe wrote:
> This patch relies on Arne's "Add send_control_channel_string_dowork
> variant" patch.
So. After we left you out in the cold for over a year (apologies
for that), we should revisit your patch set.
I checked with Arne, he says "n
Hi,
On Mon, Mar 18, 2019 at 05:16:49PM -0400, selva.n...@gmail.com wrote:
> From: Selva Nair
>
> Make clear that --dhcp-option is not processed on
> non-Windows clients and the user is expected to handle
> it using an --up script.
I'm going through "lost" patches in patchwork - and this one is
Hi,
On Mon, Aug 10, 2020 at 04:37:05PM +0200, Arne Schwabe wrote:
> This refactors the common code between mbed SSL and OpenSSL into
> export_user_keying_material and also prepares the backend functions
> to export more than one key.
I'd like to postpone this one for "after 2.5 branching" (so it
Hi,
On Mon, Aug 10, 2020 at 04:36:52PM +0200, Arne Schwabe wrote:
> Mostly C90 -> C99 cleanups and again immediately instead
> wrapping function body into if.
>
> (Review with ignore whitespace)
This does not apply without 01, and since I just asked for changes on 01,
I'm putting this one to "c
Hi,
On Mon, Aug 10, 2020 at 04:36:51PM +0200, Arne Schwabe wrote:
> - Extract data packet handling to its own function
> - Replace two instances of
> if (x) { code }
> with
> if (!x) return; code
>
> - Remove extra curly braces that were used for pre C99 code style
> to be
On 11-08-2020 10:45, Gert Doering wrote:
> Acked-by: Gert Doering
>
> Server-side and client-side tested.
>
> Not sure if I understand all possible implications of S_NORMAL_OP,
> but indeed it is not *used* anywere, except in ">= S_ACTIVE".
>
> The flow of "at which point in time we set must_ne
Acked-by: Gert Doering
Server-side and client-side tested.
Not sure if I understand all possible implications of S_NORMAL_OP,
but indeed it is not *used* anywere, except in ">= S_ACTIVE".
The flow of "at which point in time we set must_negotiate = 0"
changes a bit - the old code would do it "wh
Tested-By: Vladislav Grishenko
Read-checked with --ignore-space-change, build & tested with sample
server/client profile.
--
Best Regards, Vladislav Grishenko
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourcefo
Tested-By: Vladislav Grishenko
Read-checked with --ignore-space-change, build & tested with sample
server/client profile.
--
Best Regards, Vladislav Grishenko
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourcefo
Acked-by: Gert Doering
Server-side tested. "git show -w" shows that half of the
patch is indentation changes - and the other is "move around".
Your patch has been applied to the master branch.
commit 4b4f5fe22f8ac0ffaf32185ac995da08d524dcbd
Author: Arne Schwabe
Date: Mon Aug 10 16:37:06 2020
19 matches
Mail list logo
