On 11-08-2020 10:45, Gert Doering wrote: > Acked-by: Gert Doering <g...@greenie.muc.de> > > Server-side and client-side tested. > > Not sure if I understand all possible implications of S_NORMAL_OP, > but indeed it is not *used* anywere, except in ">= S_ACTIVE". > > The flow of "at which point in time we set must_negotiate = 0" > changes a bit - the old code would do it "when it expired AND > we're in >= S_ACTIVE", while the new code would do it "right > when setting S_ACTIVE" - which is the only place where S_ACTIVE > is set, so it would always catch said condition. This should be > totally fine. > > Your patch has been applied to the master branch.
FWIW: I agree, I don't think we need S_NORMAL_OP. Less code, more better. -Steffan _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
