Hi,
On Mon, Aug 10, 2020 at 04:36:51PM +0200, Arne Schwabe wrote:
> - Extract data packet handling to its own function
> - Replace two instances of
> if (x) { code }
> with
> if (!x) return; code
>
> - Remove extra curly braces that were used for pre C99 code style
> to be able to declare variables in the middle of a block
>
> This patch is easier to review with "ignore white space" as the
> diff is then a lot smaller in that case and the changes more obvious.
Generally, the patch works, and makes the resulting code better - but
we're not fully there yet. There is a funny germanism with "packet()"
showing up as "paket()" [which I could fix on the fly] but there is
also the labels at the end of handle_data_channel_pa(c)ket() which
are a bit awkward now - "done:" is not used anymore, "error:" is only
used once (so the caller could just increase the ->n_soft_errors and
jump to error_lite:)
So I'd rather not merge it "as it is"
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
