[Openvpn-devel] [PATCH] Fix various spelling mistakes

2019-01-23 Thread jonathan
From: Jonathan Tooker New patch, omitted changes to copyrights/licenses & changelog. --- Changes.rst | 6 +++--- INSTALL | 2 +- TODO.IPv6 | 6 +++--- configure.ac | 2

Re: [Openvpn-devel] [PATCH applied] Re: Move OpenSSL vs CNG signature digest type mapping to a function

2019-01-23 Thread Selva Nair
Hi, I noticed the uncrustify changes only this morning when rebasing the next patch for a v2. Thanks for taking care of that. This refactoring is used in the following patch 2/2 (PSS padding needed for OpenSSL 1.1.1) which Arne is reviewing. If 2.5 is far away, we may want to make 2.4.x work with

Re: [Openvpn-devel] [PATCH] Fix various spelling mistakes

2019-01-23 Thread Gert Doering
Hi, On Tue, Jan 22, 2019 at 09:31:03PM -0600, Jonathan Tooker wrote: > Fork @ github: https://github.com/JDTX/openvpn > (76ab12606155f51aaaf376a46f4a52a459af105c) > > From: Jonathan Tooker > Date: Tue, 22 Jan 2019 18:27:39 -0600 > Subject: [PATCH] Fix various spelling mistakes > > Fix spelling

[Openvpn-devel] [PATCH applied] Re: Move OpenSSL vs CNG signature digest type mapping to a function

2019-01-23 Thread Gert Doering
Your patch has been applied to the master branch. It needed a bit of massaging due to the uncrustify patches to cryptoapi.c that happened in between (f57431cdc88f2), but since the relevant conflicts were all "simple whitespace changes", fairly easily solved. >From a quick clance on cryptoapi.c in

Re: [Openvpn-devel] [PATCH 2/2] Handle PSS padding in cryptoapicert

2019-01-23 Thread Selva Nair
Hi On Wed, Jan 23, 2019 at 7:55 AM Arne Schwabe wrote: > > > Overall the code looks good. The overriding of the global RSA method is > a bit of a hack but I also do not have any better solution for this. It > might break using OpenSSL engines but that is a corner case that I would > not worry ab

[Openvpn-devel] [PATCH 2/2 v2] Handle PSS padding in cryptoapicert

2019-01-23 Thread selva . nair
From: Selva Nair For PSS padding, CNG requires the digest to be signed and the digest algorithm in use, which are not accessible via the rsa_sign and rsa_priv_enc callbacks of OpenSSL. This patch uses the EVP_KEY interface to hook to evp_pkey_sign callback if OpenSSL version is > 1.1.0. To test

Re: [Openvpn-devel] [PATCH v2] Fix various compiler warnings

2019-01-23 Thread Arne Schwabe
Am 30.10.18 um 09:53 schrieb Lev Stipakov: > From: Lev Stipakov > > This patch fixes "unused variable/unreferenced format parameter" > warnings in different places, kudos to Visual Studio compiler > for discoveing some of those. > > This also also removes unneeded uninit_management_callback_mult

Re: [Openvpn-devel] [PATCH] Fix various spelling mistakes

2019-01-23 Thread Arne Schwabe
Am 23.01.19 um 04:31 schrieb Jonathan Tooker: > Fork @ github: https://github.com/JDTX/openvpn > (76ab12606155f51aaaf376a46f4a52a459af105c) > > From: Jonathan Tooker > Date: Tue, 22 Jan 2019 18:27:39 -0600 > Subject: [PATCH] Fix various spelling mistakes > I have gone through all of the correc

Re: [Openvpn-devel] [PATCH] Fix various spelling mistakes

2019-01-23 Thread Arne Schwabe
Am 23.01.19 um 06:15 schrieb Jonathan Tooker: > Looks like I missed that and a few others! I fixed some more spelling > errors across other things. Follow up patch/commit below. If I just need > to re-make the original patch let me know. > > From: Jonathan Tooker > Date: Tue, 22 Jan 2019 23:10:33

Re: [Openvpn-devel] [PATCH 2/2] Handle PSS padding in cryptoapicert

2019-01-23 Thread Arne Schwabe
Am 07.12.18 um 20:17 schrieb selva.n...@gmail.com: > From: Selva Nair > > For PSS padding, CNG requires the digest to be signed > and the digest algorithm in use, which are not accessible > via the rsa_sign and rsa_priv_enc callbacks of OpenSSL. > This patch uses the EVP_KEY interface to hook to

Re: [Openvpn-devel] [PATCH 1/2] Move OpenSSL vs CNG signature digest type mapping to a function

2019-01-23 Thread Arne Schwabe
Am 07.12.18 um 20:17 schrieb selva.n...@gmail.com: > From: Selva Nair > > Also add a function to map OpenSSL padding identifier to > corresponding CNG constant. > > This is to help add support for additional padding > types: only refactoring, no functional changes. > I have no compile and use

Re: [Openvpn-devel] [PATCH] Add a warning that we do not officially support LibreSSL

2019-01-23 Thread Arne Schwabe
>> I considered that (modulo the sleep 60) and wrote the code to do the >> configure check, but then thought that a not-suppressible warning in the >> logs would be sufficient. I still think it is, but don't mind re-adding >> it to configure.ac if you prefer that. > > As an OpenBSD developer an