Am 23.01.19 um 06:15 schrieb Jonathan Tooker:
> Looks like I missed that and a few others! I fixed some more spelling
> errors across other things. Follow up patch/commit below. If I just need
> to re-make the original patch let me know.
> 
> From: Jonathan Tooker <jonat...@reliablehosting.com>
> Date: Tue, 22 Jan 2019 23:10:33 -0600
> Subject: [PATCH] Another set of spelling fixes
> 
> ---
>  COPYING                          |   6 +-
>  ChangeLog                        | 140 +++++++++++++++----------------
>  Changes.rst                      |   6 +-
>  INSTALL                          |   2 +-
>  TODO.IPv6                        |   6 +-
>  configure.ac                     |   2 +-
>  m4/pkg.m4                        |   2 +-
>  src/openvpn/console.h            |   2 +-
>  src/openvpn/ssl_verify_backend.h |   2 +-
>  9 files changed, 84 insertions(+), 84 deletions(-)
> 
> diff --git a/COPYING b/COPYING
> index 9c21c177..54cc9f24 100644
> --- a/COPYING
> +++ b/COPYING
> @@ -157,7 +157,7 @@ OpenSSL License:
>   * The implementation was written so as to conform with Netscapes SSL.
>   * 
>   * This library is free for commercial and non-commercial use as long as
> - * the following conditions are aheared to.  The following conditions
> + * the following conditions are adhered to.  The following conditions
>   * apply to all code found in this distribution, be it the RC4, RSA,
>   * lhash, DES, etc., code; not just the SSL code.  The SSL documentation
>   * included with this distribution is covered by the same copyright terms
> @@ -182,7 +182,7 @@ OpenSSL License:
>   *    must display the following acknowledgement:
>   *    "This product includes cryptographic software written by
>   *     Eric Young (e...@cryptsoft.com)"
> - *    The word 'cryptographic' can be left out if the rouines from the 
> library
> + *    The word 'cryptographic' can be left out if the routines from the 
> library
>   *    being used are not cryptographic related :-).
>   * 4. If you include any Windows specific code (or a derivative thereof) 
> from 
>   *    the apps directory (application code) you must include an 
> acknowledgement:
> @@ -200,7 +200,7 @@ OpenSSL License:
>   * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
>   * SUCH DAMAGE.
>   * 
> - * The licence and distribution terms for any publically available version or
> + * The licence and distribution terms for any publicly available version or
>   * derivative of this code cannot be changed.  i.e. this code cannot simply 
> be
>   * copied and put under another distribution licence
>   * [including the GNU Public Licence.]


Yes there are spelling mistakes in the license but changing someone
else's license is an absolute nogo, no matter how wrong it is spelt.

Even the current OpenSSL version (1.1.1a) has the text with the spelling
mistakes in it.

[Changelog entries]

I am not sure about the changelog. Changes.rst can be spell checked but
Changelog also doubles as a list of the git commit, so I feel it should
be the same as the commits.


> diff --git a/src/openvpn/console.h b/src/openvpn/console.h
> index 62beacae..f9481684 100644
> --- a/src/openvpn/console.h
> +++ b/src/openvpn/console.h
> @@ -35,7 +35,7 @@ struct _query_user {
>      char *prompt;             /**< Prompt to present to the user */
>      size_t prompt_len;        /**< Length of the prompt string */
>      char *response;           /**< The user's response */
> -    size_t response_len;      /**< Length the of the user reposone */
> +    size_t response_len;      /**< Length the of the user response */
>      bool echo;                /**< True: The user should see what is being 
> typed, otherwise mask it */
>  };
>  
> diff --git a/src/openvpn/ssl_verify_backend.h 
> b/src/openvpn/ssl_verify_backend.h
> index f4cc2c54..d6b31bfa 100644
> --- a/src/openvpn/ssl_verify_backend.h
> +++ b/src/openvpn/ssl_verify_backend.h
> @@ -176,7 +176,7 @@ void x509_setenv(struct env_set *es, int cert_depth, 
> openvpn_x509_cert_t *cert);
>   *
>   * The tracked attributes are stored in ll_head.
>   *
> - * @param ll_head       The x509_track to store tracked atttributes in
> + * @param ll_head       The x509_track to store tracked attributes in
>   * @param name          Name of the attribute to track
>   * @param msglevel      Message level for errors
>   * @param gc            Garbage collection arena for temp data
> -- 
> 2.20.1.windows.1
> 
> 
> 
> On 1/22/2019 9:51 PM, Simon Matter wrote:
>> Hi,
>>
>>> diff --git a/src/openvpn/console.h b/src/openvpn/console.h
>>> index 0ffd6683..62beacae 100644
>>> --- a/src/openvpn/console.h
>>> +++ b/src/openvpn/console.h
>>> @@ -33,9 +33,9 @@
>>>   */
>>> struct _query_user {
>>>      char *prompt;             /**< Prompt to present to the user */
>>> -    size_t prompt_len;        /**< Lenght of the prompt string */
>>> +    size_t prompt_len;        /**< Length of the prompt string */
>>>      char *response;           /**< The user's response */
>>> -    size_t response_len;      /**< Lenght the of the user reposone */
>>> +    size_t response_len;      /**< Length the of the user reposone */
>>                                                              ^^^^^^^^
>> response
>>
These changes are fine.

Arne

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to