Hi,
I noticed the uncrustify changes only this morning when rebasing the next
patch for a v2. Thanks for taking care of that.
This refactoring is used in the following patch 2/2 (PSS padding needed for
OpenSSL 1.1.1) which Arne is reviewing. If 2.5 is far away, we may want to
make 2.4.x work with openssl 1.1.1. That said, we could continue shipping
2.4.x for Windows built against OpenSSL 1.1.0, so I'm fine with no PSS (and
hence no OpenSSL 1.1.1) support in 2.4.
Selva
On Wed, Jan 23, 2019 at 2:08 PM Gert Doering <g...@greenie.muc.de> wrote:
> Your patch has been applied to the master branch.
>
> It needed a bit of massaging due to the uncrustify patches to cryptoapi.c
> that happened in between (f57431cdc88f2), but since the relevant conflicts
> were all "simple whitespace changes", fairly easily solved.
>
> From a quick clance on cryptoapi.c in release/2.4 it looks like this
> might also be applicable - but "by default" I won't apply pure refactoring
> changes. So: if you need this for a change that falls into release/2.4
> land ("long-term compatibility" or "bugfix"), please let me know.
>
> Test built on ubuntu 16.04/mingw.
>
> commit 0cab3475a83e9bad35b0eeb39b9ca886e6afaf1e
> Author: Selva Nair
> Date: Fri Dec 7 14:17:37 2018 -0500
>
> Move OpenSSL vs CNG signature digest type mapping to a function
>
> Signed-off-by: Selva Nair <selva.n...@gmail.com>
> Acked-by: Arne Schwabe <a...@rfc2549.org>
> Message-Id: <1544210258-8754-1-git-send-email-selva.n...@gmail.com>
> URL:
> https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17999.html
> Signed-off-by: Gert Doering <g...@greenie.muc.de>
>
>
> --
> kind regards,
>
> Gert Doering
>
>
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
