[Openvpn-devel] [PATCH] Always release dhcp address in close_tun()

2016-12-30 Thread selva . nair
From: Selva Nair Also make sure --dhcp-pre-release results in not just dhcp_release() in open_tun() but a subsequent dhcp_renew() as well. Else dhcp transaction gets aborted as this call to release() happens after the adapter status is changed to connected. Alternatively, the undocumented --dhcp

Re: [Openvpn-devel] [PATCH v2] Delete the IPv6 route to the "connected" network on tun close

2016-12-30 Thread Selva Nair
Hi, On Fri, Dec 30, 2016 at 10:58 AM, Selva Nair wrote: > > Based on Trac #807, it seems removing ipv6 address on tun close is more > than just good behaviour. Hmm.. this patch was about deleting ipv6 routes not address, so not really related to Trac 807, nor as important as I thought. Sorry f

Re: [Openvpn-devel] [PATCH v2] Delete the IPv6 route to the "connected" network on tun close

2016-12-30 Thread Selva Nair
Hi, Based on Trac #807, it seems removing ipv6 address on tun close is more than just good behaviour. A review of this patch would help. Thanks, Selva On Fri, Nov 25, 2016 at 12:21 AM, Selva Nair wrote: > This was missing on Windows when interactive service is in use. > > - Added route_ipv6_

Re: [Openvpn-devel] couple of questions on trac#665

2016-12-30 Thread Gert Doering
Hi, On Thu, Dec 29, 2016 at 10:30:58AM +0500, ?? wrote: > I would split !read || !write into 2 separate calls with separate debug log > messages... NAK on this. This code can basically not fail unless the interactive service dies - and then, it does not really matter which

Re: [Openvpn-devel] couple of questions on trac#665

2016-12-30 Thread Gert Doering
Hi, On Thu, Dec 29, 2016 at 09:56:44AM +0500, ?? wrote: > I seem to see several times issues like described in #665 It came up on openvpn-users yesterday as well, and that's a bit weird as our test set covers the case in question ("connect to different remotes on the same tap

Re: [Openvpn-devel] Fwd: Re: [Openvpn-announce] OpenVPN 2.4.0 released

2016-12-30 Thread Steffan Karger
Hi, On 29-12-16 20:06, Selva Nair wrote: > > On Thu, Dec 29, 2016 at 5:53 AM, Samuli Seppänen > wrote: > Messaggio Inoltrato > Oggetto:Re: [Openvpn-announce] OpenVPN 2.4.0 released > Data: Tue, 27 Dec 2016 22:04:23 -0600 > Mi