Hi,

On Thu, Dec 29, 2016 at 09:56:44AM +0500, ???????? ?????????????? wrote:
> I seem to see several times issues like described in #665

It came up on openvpn-users yesterday as well, and that's a bit weird
as our test set covers the case in question ("connect to different remotes
on the same tap device") and I never saw this.  Must be timing related.

> what seems to be strange is couple of things:
> 
> 1) "OR" clause. why not "AND" ?
> https://github.com/OpenVPN/openvpn/blob/master/src/openvpn/tun.c#L6012-L6013

Because both are "not".  So "if not write() or not read() -> error".

The code is correct, otherwise you'd end up with this error
message ("TUN: could not talk to service") which is not there in 
the logs.


> 2) error message seems to be irrelevant
> https://github.com/OpenVPN/openvpn/blob/master/src/openvpn/tun.c#L6034
> 
> it might be an error from earlier function calls, not only FlushIpNetTable
> itself.

How?  status is either set in line 6019 or in 6023.  There is no way
6034 can be reached without calling either the iservice-based flushing
or directly calling FlushIpNetTable() - so status is always relevant.

gert
-- 
USENET is *not* the non-clickable part of WWW!
                                                           //www.muc.de/~gert/
Gert Doering - Munich, Germany                             g...@greenie.muc.de
fax: +49-89-35655025                        g...@net.informatik.tu-muenchen.de

Attachment: signature.asc
Description: PGP signature

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to