Hi, On Thu, Dec 29, 2016 at 10:30:58AM +0500, ???????? ?????????????? wrote: > I would split !read || !write into 2 separate calls with separate debug log > messages...
NAK on this. This code can basically not fail unless the interactive
service dies - and then, it does not really matter which one failed
(because both will fail).
So unless you see *this* error message ("TUN: could not talk to service:")
and wonder whether read or write is causing is, there is no benefit in
making this part of the code more lines.
> and move FlushIpNet error closer to FlushIpNet call.
>
> right ?
No. The error check is *right* under the line where it is set.
No need to have duplicate code in both if/else clauses before that.
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
