Hi,
On Thu, Feb 25, 2016 at 4:00 PM, Fish wrote:
> +#ifndef _WIN32_H
> +#define _WIN32_H
> +
> +#if defined(_MSC_VER)
> +#define snwprintf _snwprintf
> +#endif
> +
> +#endif
>
We could've just used _snwprintf directly in the sources and avoided a new
header file. mingw has both. Well, may be so
- Include lz4 code and header in VC project files.
- Fix an issue in comp-lz4.h that prevents it from compiling under MSVC.
Signed-off-by: Fish
---
config-msvc.h | 2 ++
src/compat/compat.vcxproj | 1 +
src/compat/compat.vcxproj.filters | 3 +++
src/openvpn/c
Compiled under VS 2010/2013 and Windows 10.
The following major changes are made:
- Remove all runtime function resolving code since OpenVPN 2.4 is
targeting Vista+.
- Make sure local header inclusion uses double-quotes instead of angle
brackets.
- Update openvpnserv.vcxproj to include new sou
Hi,
On Thu, Feb 25, 2016 at 10:57:52AM -0500, Selva Nair wrote:
> > I'm a bit at a loss why it is bombing here...
>
> Ah, sorry I should have checked 32 bit compilation. Its due to missing
> includes, not a big problem for 64 bit as dll import names are not mangled,
> but in 32 bit linker may be
Patch has been applied to the master branch.
commit 9b9187031b742258b518dbde648326b3e3a8d8d8
Author: Gert Doering
List-Post: openvpn-devel@lists.sourceforge.net
Date: Thu Feb 25 15:58:32 2016 +0100
Fix openserv/validate.o linking issues on mingw.
Signed-off-by: Gert Doering
Ack
Hi,
On Thu, Feb 25, 2016 at 9:58 AM, Gert Doering wrote:
> MinGW fails linking after f3c8a04d6021 if the right header files
> ( and ) are not included.
>
> Signed-off-by: Gert Doering
> ---
> src/openvpnserv/validate.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/openvpnserv/
On Thu, Feb 25, 2016 at 7:57 AM, Gert Doering wrote:
> Hi,
>
> On Thu, Feb 25, 2016 at 01:01:52PM +0100, Gert Doering wrote:
> > ACK. Needed functionality, and the implementation looks good to me
> > (I wouldn't mind more closed scrutiny by one of the more experienced
> > windows programmers, bu
ACK, thanks.
Your patch has been applied to the master and release/2.3 branch.
commit ab0f846de6991345c30f5b69817304183d347e0e (master)
commit 22f399f5509a56c7aaa57779b14a650d33d30e5e (master)
Author: Steffan Karger
List-Post: openvpn-devel@lists.sourceforge.net
Date: Thu Feb 25 15:10:34 201
MinGW fails linking after f3c8a04d6021 if the right header files
( and ) are not included.
Signed-off-by: Gert Doering
---
src/openvpnserv/validate.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/openvpnserv/validate.c b/src/openvpnserv/validate.c
index d7446de..b5809b3 100644
--- a/
As reported in trac #582, the OCSP_check.sh script should use grep -E,
instead of grep -F when it uses ^ in the expression.
Signed-off-by: Steffan Karger
---
contrib/OCSP_check/OCSP_check.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/contrib/OCSP_check/OCSP_check.sh
ACK. Fixes the "OpenVPN.exe hanging with no understandable reason when
the log file cannot be written to" issue for good (logging on management
interface will still work).
Again, I might overlook something Windows special, but from a generic
C and "on unix, the equivalent stuff would work correct
Hi,
On Thu, Feb 25, 2016 at 01:01:52PM +0100, Gert Doering wrote:
> ACK. Needed functionality, and the implementation looks good to me
> (I wouldn't mind more closed scrutiny by one of the more experienced
> windows programmers, but since they are all too busy, my reading of
> the code will have
On 25/02/16 13:29, Gert Doering wrote:
> Please re-send (and it would be nice if you could do "git commit -s"
> for the signed-off-by: - David can explain better what the significance
> of that is, but "since we all do it", it's convention)
The reason of adding the Signed-off-by is to have a bette
Hi,
On Sat, Feb 13, 2016 at 04:15:07PM -0500, Selva Nair wrote:
> The patch is split into two commits for ease of review
> (i) Refactor the code changing no functionality
> -- most of win_wfp_block_dns is moved to a new file and
>made independent of the rest of the code
>
> (ii) Impl
Thanks, and sorry for the long delay.
The ACK from Selva is in a different thread, but referring to this patch
(Message-ID:
)
I have added a reference to trac #648 and reformatted the commit message
slightly (too-long lines get wrapped in weird ways by git am).
Your patch has been applied to t
Hi,
On Mon, Feb 22, 2016 at 03:09:23PM -0500, Fish wrote:
> - Include lz4 code and header in VC project files.
> - Fix an issue in comp-lz4.h that prevents it from compiling under MSVC.
The patch does not apply for me
Applying: Add lz4 support to MSVC project.
error: patch failed: src/openvpn/op
Hi,
On Mon, Feb 22, 2016 at 03:41:57PM -0500, Fish wrote:
> Compiled under VS 2010/2013 and Windows 10.
>
> The following major changes are made:
> - Remove all runtime function resolving code since OpenVPN 2.4 is
> targeting Vista+.
> - Make sure local header inclusion uses double-quotes inste
ACK. Needed functionality, and the implementation looks good to me
(I wouldn't mind more closed scrutiny by one of the more experienced
windows programmers, but since they are all too busy, my reading of
the code will have to do). I fixed one typo ("Retrurns") in a comment.
Your patch has been a
18 matches
Mail list logo
