On Thu, Feb 25, 2016 at 7:57 AM, Gert Doering <g...@greenie.muc.de> wrote:
> Hi,
>
> On Thu, Feb 25, 2016 at 01:01:52PM +0100, Gert Doering wrote:
> > ACK. Needed functionality, and the implementation looks good to me
> > (I wouldn't mind more closed scrutiny by one of the more experienced
> > windows programmers, but since they are all too busy, my reading of
> > the code will have to do). I fixed one typo ("Retrurns") in a comment.
> >
> > Your patch has been applied to the master branch.
>
> Mmmh. It breaks compilation on Samuli's buildbot...
>
> /bin/bash ../../libtool --tag=CC --mode=link i686-w64-mingw32-gcc
> -municode -D_UNICODE -UNTDDI_VERSION -U_WIN32_WINNT
> -D_WIN32_WINNT=_WIN32_WINNT_VISTA -o openvpnserv.exe
> openvpnserv-common.o openvpnserv-automatic.o openvpnserv-interactive.o
> openvpnserv-service.o openvpnserv-validate.o openvpnserv_resources.o
> -ladvapi32 -luserenv -liphlpapi -lshlwapi -lnetapi32 -lws2_32
> libtool: link: i686-w64-mingw32-gcc -municode -D_UNICODE -UNTDDI_VERSION
> -U_WIN32_WINNT -D_WIN32_WINNT=_WIN32_WINNT_VISTA -o .libs/openvpnserv.exe
> openvpnserv-common.o openvpnserv-automatic.o openvpnserv-interactive.o
> openvpnserv-service.o openvpnserv-validate.o openvpnserv_resources.o
> -ladvapi32 -luserenv -liphlpapi -lshlwapi -lnetapi32 -lws2_32
> openvpnserv-validate.o:validate.c:(.text+0x54): undefined reference to
> `PathIsRelativeW'
> openvpnserv-validate.o:validate.c:(.text+0x31f): undefined reference to
> `NetApiBufferFree'
>
> the microsoft documentation says, PathIsRelativeW() is in "Shlwapi.dll",
> and I can see the link line pulling that in... "NetApiBufferFree()" is
> in "Netapi32.dll", and that is *also* linked...
>
> I'm a bit at a loss why it is bombing here...
>
Ah, sorry I should have checked 32 bit compilation. Its due to missing
includes, not a big problem for 64 bit as dll import names are not mangled,
but in 32 bit linker may be looking for _PathIsRelativeW etc.. (I think..)
Anyway my mistake.. Will do a patch..
Selva
