Hi, On Sat, Feb 13, 2016 at 04:15:07PM -0500, Selva Nair wrote: > The patch is split into two commits for ease of review > (i) Refactor the code changing no functionality > -- most of win_wfp_block_dns is moved to a new file and > made independent of the rest of the code > > (ii) Implement a handler for blocking dns in the interactive service > > > With (i) and (ii) --block-outside-dns should work without admin privileges > if the interactive service installed and running and GUI is started as user.
This looks good to me. Alas, I also need to ask you for a v2 of the (i) patch - I've just merged Valdikss' patch to make the block-outside-dns code work on Vista (trac #648), and now the code slab that gets moved out of win32.c has been changed. Of course I could adjust (i) accordingly, but for maximum transparency, I would perfer to have the actual change on the list and in the archives... thanks gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie.muc.de fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
signature.asc
Description: PGP signature