Hi,
On Thu, Sep 04, 2014 at 01:13:17PM +0200, Steffan Karger wrote:
> Attached a patch for a change suggested by Jann Horn, to remove the
> quadratic complexity from openvpn_base64_decode().
[..]
> That said, I do like the suggestion to make the code constant time. I'd
> say it should be applied t
Hi,
On Fri, Sep 05, 2014 at 05:25:30PM +0200, dav...@redhat.com wrote:
> @@ -365,27 +365,30 @@ openvpn_popen (const struct argv *a, const struct
> env_set *es)
> pid = fork ();
> if (pid == (pid_t)0) /* child side */
> {
> -
Hi,
On Fri, Sep 05, 2014 at 05:25:29PM +0200, dav...@redhat.com wrote:
>return (lstat("/sys/fs/cgroup", &a) == 0)
> - && (lstat("/sys/fs/cgroup/systemd", &b) == 0)
> - && (a.st_dev != b.st_dev);
> -
> +&& (lstat("/sys/fs/cgroup/systemd", &b) == 0)
> +&& (stat(SYSTEMD_ASK_PA
Hi,
On Fri, Sep 05, 2014 at 05:25:28PM +0200, dav...@redhat.com wrote:
> From: David Sommerseth
>
> Commit 9449e6a9eba30c9ed054f57d630a88c9f087080f introduced the
> openvpn_popen() function to support retrieving passwords via systemd.
>
> It was discovered that the child processes openvpn fork(
Hi,
On Fri, Sep 05, 2014 at 05:25:31PM +0200, dav...@redhat.com wrote:
> Reformatted to 2 space indents (no tabs).
NAK, as our current coding style is "2 space indents, tab=8" - even if
not consistently used everywhere, *if* we do reformatting at this stage,
do it towards the current style.
(I a
Hi,
On Fri, Sep 05, 2014 at 04:07:27PM +0200, David Sommerseth wrote:
> On 03/07/14 22:24, Mike Gilbert wrote:
> > Gentoo Linux installs this in /usr/bin by default. Also, the user
> > may have installed it in /usr/local/bin if building from source.
>
> ACK. Also considering that Fedora have mov
