Hi, On Fri, Sep 05, 2014 at 05:25:28PM +0200, dav...@redhat.com wrote: > From: David Sommerseth <dav...@redhat.com> > > Commit 9449e6a9eba30c9ed054f57d630a88c9f087080f introduced the > openvpn_popen() function to support retrieving passwords via systemd. > > It was discovered that the child processes openvpn fork()ed would > be lingering around until openvpn stopped. This was due to the lack > of a wait() call. > > This patch also cleans up a few minor white-space issues in the same > code segment. > > [v2 proper initialisation of status variable]
ACK.
(As a side note: not that the initialization of "status" makes any sense
here :-), as even if waitpid() wouldn't set it due to some freak incident,
it will never be used afterwards. But the general introduction of wait()
in one of its forms is needed here, yes)
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
pgpvG7u27A3zk.pgp
Description: PGP signature
