Hi,
On Fri, Sep 05, 2014 at 05:25:30PM +0200, dav...@redhat.com wrote:
> @@ -365,27 +365,30 @@ openvpn_popen (const struct argv *a, const struct
> env_set *es)
> pid = fork ();
> if (pid == (pid_t)0) /* child side */
> {
> - close (pipe_stdout[0]);
> + close (pipe_stdout[0]); /* Close read end */
> dup2 (pipe_stdout[1],1);
> execve (cmd, argv, envp);
> + close (pipe_stdout[1]);
> exit (127);
NAK, as that addition does not have any benefit. Even if the execve()
fails, the next thing is an exit(), which will close all file descriptors
anyway. It's just extra code that impairs reading.
The rest of the change would get an feature- and code-ACK, though :)
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
pgpH7dZJC2lhj.pgp
Description: PGP signature
