Re: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml

2011-02-03 Thread Kent Quirk
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/108/#review318 --- Ship it! I'm happy now. :) - Kent On Feb. 3, 2011, 8:20 a.m.,

Re: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml

2011-02-03 Thread Vadim ProductEngine
> On Feb. 2, 2011, 8:56 a.m., Kent Quirk wrote: > > So I have a couple of issues with this patch: > > > > * I'm worried about the translation impact, how these strings are used and > > where. Should they be localized? Should they not be localized? I find it > > hard to believe that we ONLY nee

Re: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml

2011-02-03 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/108/ --- (Updated Feb. 3, 2011, 8:20 a.m.) Review request for Viewer. Changes

Re: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml

2011-02-02 Thread Torben Trautman
> On Feb. 2, 2011, 8:56 a.m., Kent Quirk wrote: > > So I have a couple of issues with this patch: > > > > * I'm worried about the translation impact, how these strings are used and > > where. Should they be localized? Should they not be localized? I find it > > hard to believe that we ONLY nee

Re: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml

2011-02-02 Thread Kent Quirk
> On Feb. 2, 2011, 8:56 a.m., Kent Quirk wrote: > > So I have a couple of issues with this patch: > > > > * I'm worried about the translation impact, how these strings are used and > > where. Should they be localized? Should they not be localized? I find it > > hard to believe that we ONLY nee

Re: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml

2011-02-02 Thread Vadim ProductEngine
> On Feb. 2, 2011, 8:56 a.m., Kent Quirk wrote: > > So I have a couple of issues with this patch: > > > > * I'm worried about the translation impact, how these strings are used and > > where. Should they be localized? Should they not be localized? I find it > > hard to believe that we ONLY nee

Re: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml

2011-02-02 Thread Kent Quirk
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/108/#review307 --- So I have a couple of issues with this patch: * I'm worried about

Re: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml

2011-02-01 Thread Vadim ProductEngine
> On Jan. 31, 2011, 3:19 p.m., Merov Linden wrote: > > Good I think. I'm assuming that localization hasn't left those outside > > strings.xml for a reason (like: make sure no one ever tries to translate > > them). No, there was no reason. It's just only two keys were initially localized (Home

Re: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml

2011-01-31 Thread Merov Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/108/#review291 --- Ship it! Good I think. I'm assuming that localization hasn't left

Re: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml

2011-01-26 Thread Vadim ProductEngine
> On Jan. 20, 2011, 6:46 a.m., Seth ProductEngine wrote: > > No missing string warnings while looking through the menu with this patch. > > Twisted Laws wrote: > 2011-01-26T19:57:39Z WARNING: LLTrans::getString: ONCE: Missing String in > strings.xml: [LSLTipText_llSound] > 2011-01-26T19

Re: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml

2011-01-26 Thread Twisted Laws
> On Jan. 20, 2011, 6:46 a.m., Seth ProductEngine wrote: > > No missing string warnings while looking through the menu with this patch. 2011-01-26T19:57:39Z WARNING: LLTrans::getString: ONCE: Missing String in strings.xml: [LSLTipText_llSound] 2011-01-26T19:30:59Z WARNING: LLTrans::findString:

Re: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml

2011-01-20 Thread Seth ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/108/#review208 --- Ship it! No missing string warnings while looking through the men